Visitar URL original
Update NuGet package description by David-Engel · Pull Request #1973 · dotnet/SqlClient · GitHub
Skip to content

Update NuGet package description - #1973

Merged
David-Engel merged 3 commits into
mainfrom
David-Engel-patch-1
Apr 4, 2023
Merged

David-Engel merged 3 commits into
mainfrom
David-Engel-patch-1

Conversation

@David-Engel

@David-Engel David-Engel commented Mar 28, 2023 •

Copy link
Copy Markdown
Contributor

Addresses #1963
Make the description clear that it is a replacement for SDS and is the latest library for SQL connectivity.

Ideally, the first couple of lines would help differentiate which library to use when bringing it in to VS:
image

CC: @ericstj , @sharwell

Make the description clear that it is a replacement for SDS and is the latest library for SQL connectivity.
@ericstj

ericstj commented Mar 28, 2023

Copy link
Copy Markdown
Member

This looks good to me. @sharwell would this new description help solve the problem you raised?

@sharwell

Copy link
Copy Markdown

Yes, the new description would have saved me time. 👍

@ErikEJ

ErikEJ commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

Could also be "The current" or "The modern"

@codecov

codecov Bot commented Mar 31, 2023 •

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.72 ⚠️

Comparison is base (b534f15) 70.50% compared to head (29ccb77) 69.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1973      +/-   ##
==========================================
- Coverage   70.50%   69.78%   -0.72%     
==========================================
  Files         306      306              
  Lines       61667    61667              
==========================================
- Hits        43480    43036     -444     
- Misses      18187    18631     +444     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 73.30% <ø> (+0.05%) ⬆️
netfx 67.97% <ø> (-1.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DavoudEshtehari DavoudEshtehari added the Area\Documentation Use this for issues that requires changes in public documentations/samples. label Apr 3, 2023
@David-Engel
David-Engel merged commit a5ad838 into main Apr 4, 2023
@David-Engel
David-Engel deleted the David-Engel-patch-1 branch April 4, 2023 15:57
DavoudEshtehari added a commit to DavoudEshtehari/SqlClient that referenced this pull request Apr 17, 2023
DavoudEshtehari pushed a commit to DavoudEshtehari/SqlClient that referenced this pull request Apr 21, 2023
Make the description clear that it is a replacement for SDS and is the latest library for SQL connectivity.
kant2002 pushed a commit to kant2002/SqlClient that referenced this pull request Jun 29, 2023
Make the description clear that it is a replacement for SDS and is the latest library for SQL connectivity.
@yerald-mora

Copy link
Copy Markdown

@David-Engel i'm still not able to see the new descriptions when browsing the packages in Microsoft Visual Studio Community 2022 (64-bit) - Current
Version 17.5.2
image

@David-Engel

Copy link
Copy Markdown
Contributor Author

@yerald-mora You will only see it for releases starting with 5.2 preview 1.

https://www.nuget.org/packages/Microsoft.Data.SqlClient/5.2.0-preview3.23201.1#readme-body-tab

There is a way to edit the readme for previous releases, but I haven't looked into that, yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Documentation Use this for issues that requires changes in public documentations/samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants