Visitar URL original
Expose SSPI context provider as public by twsouthwick · Pull Request #2494 · dotnet/SqlClient · GitHub
Skip to content

Expose SSPI context provider as public - #2494

Merged
cheenamalhotra merged 16 commits into
dotnet:mainfrom
twsouthwick:public
Feb 19, 2026
Merged

Expose SSPI context provider as public#2494
cheenamalhotra merged 16 commits into
dotnet:mainfrom
twsouthwick:public

Conversation

@twsouthwick

@twsouthwick twsouthwick commented May 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This change:

  • Adds a property to SqlConnection to allow setting a provider
  • Plumbs that property into the TdsParser so that it can be used if set

Fixes #2253

@twsouthwick twsouthwick mentioned this pull request May 8, 2024
Closed
8 of 10 tasks
@twsouthwick twsouthwick changed the title Expose SSPI context provider as public Expose SSPI context provider as public May 8, 2024
@twsouthwick
twsouthwick force-pushed the public branch 3 times, most recently from e16f2c8 to cfcf164 Compare March 3, 2025 19:42
@codecov

codecov Bot commented Mar 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (28caf4c) to head (05d4a8d).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #2494       +/-   ##
==========================================
- Coverage   90.82%       0   -90.83%     
==========================================
  Files           6       0        -6     
  Lines         316       0      -316     
==========================================
- Hits          287       0      -287     
+ Misses         29       0       -29
Flag Coverage Δ
addons ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

nhart12
nhart12 reviewed Mar 11, 2025
View reviewed changes
Comment thread src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.cs Resolved
nhart12
nhart12 reviewed Mar 11, 2025
View reviewed changes
Comment thread src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.cs Resolved
benrr101
benrr101 previously requested changes Apr 2, 2025
View reviewed changes

@benrr101 benrr101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, really like the goal and implementation. Most of my comments are style related, since I'm sure my colleagues have tackled the bigger questions.

Comment thread src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SSPI/SSPIContextProvider.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SSPI/NativeSSPIContextProvider.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SSPI/SSPIContextProvider.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionPoolKey.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionPoolKey.cs Resolved
paulmedynski
paulmedynski requested changes Apr 2, 2025
View reviewed changes

@paulmedynski paulmedynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made an initial pass, and came up with some questions/comments.

Comment thread doc/snippets/Microsoft.Data.SqlClient/SSPIContextProvider.xml Resolved
Comment thread doc/snippets/Microsoft.Data.SqlClient/SSPIContextProvider.xml Resolved
Comment thread doc/snippets/Microsoft.Data.SqlClient/SqlConnection.xml Resolved
Comment thread src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SSPI/NegotiateSSPIContextProvider.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionPoolKey.cs Resolved
@paulmedynski paulmedynski self-assigned this Apr 2, 2025
@twsouthwick
twsouthwick force-pushed the public branch 6 times, most recently from 380e896 to 2039bd9 Compare May 1, 2025 19:37
paulmedynski
paulmedynski requested changes May 13, 2025
View reviewed changes

@paulmedynski paulmedynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Factory vs instance in the netfx code, and a few questions about docs.

Comment thread doc/snippets/Microsoft.Data.SqlClient/SspiAuthenticationParameters.xml Resolved
Comment thread src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs Resolved
@twsouthwick
twsouthwick force-pushed the public branch 4 times, most recently from 5bb128f to 8937cb7 Compare May 13, 2025 14:58
@twsouthwick
twsouthwick marked this pull request as ready for review May 13, 2025 18:40
nhart12
nhart12 approved these changes May 13, 2025
View reviewed changes

@nhart12 nhart12 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest package still works for our use-case

This was referenced Nov 4, 2026
Closed
Open
Closed
Open
Closed
Merged
Open
Closed
Closed
Closed
Open
Merged
Closed
Merged
Open
Open
@MZurmuehlen89 MZurmuehlen89 mentioned this pull request Nov 10, 2026
Closed
This was referenced Nov 10, 2026
Open
Closed
Open
Closed
Merged
Merged
Open
Open
Open
Open
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaigle mdaigle mdaigle left review comments
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes
@paulmedynski paulmedynski paulmedynski approved these changes
@benrr101 benrr101 Awaiting requested review from benrr101
@David-Engel David-Engel Awaiting requested review from David-Engel
+1 more reviewer
@nhart12 nhart12 nhart12 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@paulmedynski paulmedynski

Labels

Public API 🆕 Issues/PRs that introduce new APIs to the driver.

Projects

SqlClient Board
Status: Done

Milestone

7.0.0-preview4

Development

Successfully merging this pull request may close these issues.

Add hook for custom SSPI context for SqlConnection instances

9 participants

@twsouthwick @paulmedynski @mdaigle @benrr101 @0xced @cheenamalhotra @nhart12 @David-Engel