Visitar URL original
Enable vector tests and validate ref assembly for vector APIs by apoorvdeshmukh · Pull Request #3559 · dotnet/SqlClient · GitHub
Skip to content

Enable vector tests and validate ref assembly for vector APIs - #3559

Merged
apoorvdeshmukh merged 10 commits into
dotnet:mainfrom
apoorvdeshmukh:dev/ad/vectorNullFix
Sep 2, 2025
Merged

Enable vector tests and validate ref assembly for vector APIs#3559
apoorvdeshmukh merged 10 commits into
dotnet:mainfrom
apoorvdeshmukh:dev/ad/vectorNullFix

Conversation

@apoorvdeshmukh

@apoorvdeshmukh apoorvdeshmukh commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

Description

This commit enable the vector tests against Azure SQLDb Instance add adds testcase to validate ref assembly for vector APIs.

Testing

Vector tests for backward compatibility scenarios and native testcases.

Guidelines

Please review the contribution guidelines before submitting a pull request:

Copilot AI review requested due to automatic review settings August 12, 2025 13:57
@apoorvdeshmukh
apoorvdeshmukh requested a review from a team as a code owner August 12, 2025 13:57
Copilot AI reviewed Aug 12, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables vector tests against Azure SQLDb instances and adds validation for vector API reference assemblies. The changes focus on making vector functionality testable in Azure environments and ensuring API completeness.

  • Enables vector support for Azure SQL Database instances by updating the IsVectorSupported flag
  • Adds DisableDiscoveryEnumeration = true to vector test methods to optimize test discovery
  • Includes a new test case to validate vector API functionality and reference assembly completeness

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
NativeVectorFloat32Tests.cs Adds DisableDiscoveryEnumeration to test attributes and includes new VectorAPITest method for API validation
DataTestUtility.cs Enables vector support for Azure SQL Database by changing IsVectorSupported logic
SqlVector.cs Fixes XML documentation comment reference path

Comment thread src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/VectorTest/NativeVectorFloat32Tests.cs Resolved
paulmedynski
paulmedynski requested changes Aug 12, 2025
View reviewed changes

@paulmedynski paulmedynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment needed. I'm not sure if Copilot is correct with its suggestion.

Comment thread src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs Resolved
@cheenamalhotra

cheenamalhotra commented Aug 12, 2025

Copy link
Copy Markdown
Member

@apoorvdeshmukh please port this PR to release/6.1 as well on merge.

@apoorvdeshmukh apoorvdeshmukh mentioned this pull request Aug 12, 2025
Merged
paulmedynski
paulmedynski previously approved these changes Aug 12, 2025
View reviewed changes
@paulmedynski paulmedynski linked an issue Aug 12, 2025 that may be closed by this pull request
Test | Enable JSON tests in ManualTests project #3430
Open
@cheenamalhotra cheenamalhotra removed a link to an issue Aug 13, 2025
Test | Enable JSON tests in ManualTests project #3430
Open
@cheenamalhotra

cheenamalhotra commented Aug 13, 2025

Copy link
Copy Markdown
Member

@paulmedynski @apoorvdeshmukh I think JSON tests enablement will be done separately, and its not covered in this PR.

@paulmedynski paulmedynski self-assigned this Aug 27, 2025
@mdaigle mdaigle self-assigned this Aug 27, 2025
paulmedynski
paulmedynski previously approved these changes Aug 28, 2025
View reviewed changes
paulmedynski
paulmedynski requested changes Aug 29, 2025
View reviewed changes

@paulmedynski paulmedynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request.

Comment thread src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs Resolved
This was referenced Nov 6, 2026
Closed
Open
Open
Closed
Merged
Open
Closed
Closed
Closed
Open
Merged
Closed
Merged
Open
@MZurmuehlen89 MZurmuehlen89 mentioned this pull request Nov 10, 2026
Closed
This was referenced Nov 10, 2026
Open
Closed
Open
Closed
Merged
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mdaigle mdaigle mdaigle approved these changes
@paulmedynski paulmedynski paulmedynski approved these changes
+1 more reviewer
@edwardneal edwardneal edwardneal left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mdaigle mdaigle

@paulmedynski paulmedynski

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@apoorvdeshmukh @cheenamalhotra @mdaigle @paulmedynski @edwardneal