Visitar URL original
[6.1] Avoid unintended SPN generation for non-integrated authentication on native SNI path by apoorvdeshmukh · Pull Request #3946 · dotnet/SqlClient · GitHub
Skip to content

[6.1] Avoid unintended SPN generation for non-integrated authentication on native SNI path - #3946

Merged
apoorvdeshmukh merged 1 commit into
release/6.1from
dev/ad/port3929to61
Feb 17, 2026
Merged

[6.1] Avoid unintended SPN generation for non-integrated authentication on native SNI path#3946
apoorvdeshmukh merged 1 commit into
release/6.1from
dev/ad/port3929to61

Conversation

@apoorvdeshmukh

@apoorvdeshmukh apoorvdeshmukh commented Feb 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Ports #3929 to release/6.1

Issues

Fixes #3941

Testing

Issue impacted only the netcore app and not the netfx app.
Added unit test to validate the code changes.
E2E Validation using the repro provided in #3523 and env setup as mentioned in #3929

Without the fix

Data Source=tcp:XXXXXX,XXXX;Initial Catalog=Demo2;User ID=XX;Password=XXXXXXXX;Connect Timeout=10;Encrypt=True;Trust Server Certificate=True;Application Name="Connection test"
Connection successful!
Time taken to connect: 5185 ms ms

With the fix

Data Source=tcp:XXXXXX,XXXX;Initial Catalog=Demo2;User ID=XX;Password=XXXXXXXX;Connect Timeout=10;Encrypt=True;Trust Server Certificate=True;Application Name="Connection test"
Connection successful!
Time taken to connect: 263 ms

Guidelines

Please review the contribution guidelines before submitting a pull request:

@apoorvdeshmukh
apoorvdeshmukh requested a review from a team as a code owner February 10, 2026 15:35
Copilot AI review requested due to automatic review settings February 10, 2026 15:35
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Feb 10, 2026
Copilot AI reviewed Feb 10, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Backports PR #3929 to release/6.1, adjusting native SNI connection setup so SPN generation is only triggered for integrated security, avoiding unnecessary DNS/SPN work for non-integrated auth modes (e.g., SQL auth) on Windows native SNI.

Changes:

  • Normalize serverSPN based on authentication mode before calling into native SNI (empty string only used to trigger SPN generation for integrated security; otherwise avoid generation).
  • Adjust resolvedSpn creation to only occur when a non-empty SPN is present after native SNI setup.
  • Add a unit test intended to validate SPN normalization behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectNative.cs Introduces SPN normalization helper and updates native handle creation logic to avoid unintended SPN generation for non-integrated auth.
src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/TdsParserStateObjectNativeTests.cs Adds a unit test for SPN normalization logic (currently gated in a way that likely prevents it from compiling/running).

Comment thread src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectNative.cs Resolved
Comment thread ...t.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/TdsParserStateObjectNativeTests.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectNative.cs Resolved
@paulmedynski paulmedynski moved this from To triage to In review in SqlClient Board Feb 10, 2026
@priyankatiwari08 priyankatiwari08 self-assigned this Feb 12, 2026
@paulmedynski paulmedynski self-assigned this Feb 12, 2026
@apoorvdeshmukh
apoorvdeshmukh merged commit cfaf082 into release/6.1 Feb 17, 2026
280 checks passed
@apoorvdeshmukh
apoorvdeshmukh deleted the dev/ad/port3929to61 branch February 17, 2026 06:41
@github-project-automation github-project-automation Bot moved this from In review to Done in SqlClient Board Feb 17, 2026
@mdaigle mdaigle added this to the 6.1.5 milestone Feb 25, 2026
@mdaigle mdaigle mentioned this pull request Feb 25, 2026
Closed
@mdaigle mdaigle mentioned this pull request Apr 1, 2026
Open
@paulmedynski paulmedynski changed the title Port #3929 to release/6.1 [6.1] Avoid unintended SPN generation for non-integrated authentication on native SNI path Apr 6, 2026
@paulmedynski paulmedynski linked an issue Apr 6, 2026 that may be closed by this pull request
Large Performance Difference between .NET 4.8 and .NET 10 when Connecting to Remote Database #3984
Closed
This was referenced Apr 27, 2026
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Open
This was referenced Oct 19, 2026
Closed
Closed
Closed
Open
Merged
Closed
Closed
Open
Open
Closed
Closed
Closed
Merged
Open
Open
Open
Open
Open
Open
This was referenced Oct 26, 2026
Closed
Closed
Closed
This was referenced Nov 2, 2026
Closed
Closed
Open
Open
This was referenced Nov 9, 2026
Open
Open
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@paulmedynski paulmedynski paulmedynski approved these changes
@priyankatiwari08 priyankatiwari08 priyankatiwari08 approved these changes

Assignees

@paulmedynski paulmedynski

@priyankatiwari08 priyankatiwari08

Labels

None yet

Projects

SqlClient Board
Status: Done

Milestone

6.1.5

Development

Successfully merging this pull request may close these issues.

Large Performance Difference between .NET 4.8 and .NET 10 when Connecting to Remote Database

5 participants

@apoorvdeshmukh @paulmedynski @priyankatiwari08 @mdaigle