Visitar URL original
SqlBatchCommand support CommandBehavior by campersau · Pull Request #4125 · dotnet/SqlClient · GitHub
Skip to content

SqlBatchCommand support CommandBehavior - #4125

Merged
mdaigle merged 15 commits into
dotnet:mainfrom
campersau:GetColumnSchemaKeyInfo
Jun 24, 2026
Merged

SqlBatchCommand support CommandBehavior#4125
mdaigle merged 15 commits into
dotnet:mainfrom
campersau:GetColumnSchemaKeyInfo

Conversation

@campersau

@campersau campersau commented Apr 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

#1825 added the Batch APIs and also added a CommandBehavior property to SqlBatchCommand which was completly unused.
Note: SqlBatchCommand.CommandBehavior is a custom property in SqlClient which isn't in the DbBatchCommand

Also the CommandBehavior for ExecuteReader was ignored.

This PR enables the use of the SqlBatchCommand.CommandBehavior and also supports passing CommandBehavior to ExecuteReader.

Issues

Fixes #4083

Testing

Added tests for passing CommandBehavior.SchemaOnly | CommandBehavior.KeyInfo to SqlBatchCommand.CommandBehavior.
Added tests for passing CommandBehavior.CloseConnection to ExecuteReader.

@campersau
campersau requested a review from a team as a code owner April 1, 2026 12:12
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Apr 1, 2026
campersau
campersau commented Apr 1, 2026
View reviewed changes
Comment thread src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlBatch.cs Resolved
@mdaigle mdaigle moved this from To triage to In review in SqlClient Board Apr 1, 2026
@mdaigle mdaigle added this to the 7.1.0-preview1 milestone Apr 1, 2026
campersau
campersau commented Apr 21, 2026
View reviewed changes
Comment thread src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/Batch/BatchTests.cs Resolved
@campersau
campersau force-pushed the GetColumnSchemaKeyInfo branch from 0629d0c to 19a768e Compare April 21, 2026 17:51
@campersau
campersau force-pushed the GetColumnSchemaKeyInfo branch from 19a768e to fe1ee31 Compare April 21, 2026 17:53
cheenamalhotra
cheenamalhotra previously approved these changes May 7, 2026
View reviewed changes

@cheenamalhotra cheenamalhotra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cheenamalhotra

cheenamalhotra commented May 7, 2026

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

azure-pipelines Bot commented May 7, 2026

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@codecov

codecov Bot commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.74%. Comparing base (c724554) to head (2ff5fe5).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...SqlClient/src/Microsoft/Data/SqlClient/SqlBatch.cs 88.46% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4125      +/-   ##
==========================================
- Coverage   66.57%   64.74%   -1.83%     
==========================================
  Files         284      279       -5     
  Lines       43301    66225   +22924     
==========================================
+ Hits        28827    42879   +14052     
- Misses      14474    23346    +8872
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 64.74% <90.62%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mdaigle
mdaigle requested changes May 12, 2026
View reviewed changes

@mdaigle mdaigle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I have some concerns about existing behavior that we have copied over without explanation and I would like to remove any unnecessary refactors.

Comment thread src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/Batch/BatchTests.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlCommand.Reader.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlCommand.Reader.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlBatch.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlBatch.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlCommand.cs Resolved
Comment thread src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/Batch/BatchTests.cs Resolved
@github-project-automation github-project-automation Bot moved this from In review to In progress in SqlClient Board May 12, 2026
@mdaigle

mdaigle commented May 15, 2026

Copy link
Copy Markdown
Contributor

Thank you for making those changes. I'll do another review pass on Monday.

This was referenced Nov 11, 2026
Merged
Open
Open
Closed
Closed
Closed
Open
Closed
Open
Closed
Merged
Merged
Open
Closed
Merged
Open
Merged
Open
Open
Closed
Closed
Merged
Open
Open
Open
Open
Open
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaigle mdaigle mdaigle approved these changes
@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

Assignees

@mdaigle mdaigle

@cheenamalhotra cheenamalhotra

Labels

Public API 🆕 Issues/PRs that introduce new APIs to the driver.

Projects

SqlClient Board
Status: Done

Milestone

7.1.0-preview2

Development

Successfully merging this pull request may close these issues.

SqlBatchCommand.CommandBehavior is unused

4 participants

@campersau @cheenamalhotra @mdaigle @paulmedynski