Visitar URL original
Improve `EnclaveDiffieHellmanInfo.Size` by jnyrup · Pull Request #4346 · dotnet/SqlClient · GitHub
Skip to content

Improve EnclaveDiffieHellmanInfo.Size - #4346

Merged
cheenamalhotra merged 2 commits into
dotnet:mainfrom
jnyrup:coalesce
Jun 10, 2026
Merged

Improve EnclaveDiffieHellmanInfo.Size#4346
cheenamalhotra merged 2 commits into
dotnet:mainfrom
jnyrup:coalesce

Conversation

@jnyrup

@jnyrup jnyrup commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Description

Parenthesize ?? as + binds stronger

Perhaps this let's us uncomment the following Debug.Asserts?
Let me know if I should try uncomment the asserts and see if CI is green.

SqlClient/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/VirtualSecureModeEnclaveProvider.cs

Lines 156 to 157 in 7721c98

// TODO(GH-3604): Fix this failing assertion.
// Debug.Assert(offset == attestationInfo.Length, $"{offset} == {attestationInfo.Length}");

SqlClient/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/AzureAttestationBasedEnclaveProvider.cs

Lines 211 to 212 in 7721c98

// TODO(GH-3604): Fix this failing assertion.
// Debug.Assert(offset == attestationInfo.Length);

Issues

Testing

Guidelines

Please review the contribution guidelines before submitting a pull request:

@jnyrup
Improve EnclaveDiffieHellmanInfo.Size
c412242 
Parenthesize `??` as `+` binds stronger
@jnyrup
jnyrup requested a review from a team as a code owner June 7, 2026 16:08
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Jun 7, 2026
cheenamalhotra
cheenamalhotra previously approved these changes Jun 9, 2026
View reviewed changes
@cheenamalhotra cheenamalhotra added this to the 7.1.0-preview2 milestone Jun 9, 2026
@cheenamalhotra cheenamalhotra self-assigned this Jun 9, 2026
paulmedynski
paulmedynski requested changes Jun 9, 2026
View reviewed changes

@paulmedynski paulmedynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please uncomment the Debug.Assert()s that you mentioned, and let's see what happens :) The PR pipelines compile and run the tests in Debug configuration.

@github-project-automation github-project-automation Bot moved this from To triage to Waiting for customer in SqlClient Board Jun 9, 2026
@paulmedynski paulmedynski self-assigned this Jun 9, 2026
@paulmedynski
paulmedynski enabled auto-merge (squash) June 9, 2026 17:32
auto-merge was automatically disabled June 9, 2026 19:24

Head branch was pushed to by a user without write access

@paulmedynski

paulmedynski commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

/azp run

@paulmedynski paulmedynski moved this from Waiting for customer to In review in SqlClient Board Jun 10, 2026
@azure-pipelines

azure-pipelines Bot commented Jun 10, 2026

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@cheenamalhotra
cheenamalhotra enabled auto-merge (squash) June 10, 2026 17:56
@cheenamalhotra
cheenamalhotra merged commit 6494816 into dotnet:main Jun 10, 2026
303 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in SqlClient Board Jun 10, 2026
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.04%. Comparing base (3488b36) to head (eceb1d3).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...a/SqlClient/AlwaysEncryptedEnclaveProviderUtils.cs 0.00% 1 Missing ⚠️
.../SqlClient/AzureAttestationBasedEnclaveProvider.cs 0.00% 1 Missing ⚠️
...Data/SqlClient/VirtualSecureModeEnclaveProvider.cs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4346      +/-   ##
==========================================
- Coverage   66.55%   64.04%   -2.51%     
==========================================
  Files         285      280       -5     
  Lines       43311    66162   +22851     
==========================================
+ Hits        28824    42371   +13547     
- Misses      14487    23791    +9304
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 64.04% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jnyrup
jnyrup deleted the coalesce branch June 10, 2026 20:57
@dependabot dependabot Bot mentioned this pull request Jul 13, 2026
Closed
cheenamalhotra pushed a commit that referenced this pull request Jul 14, 2026
@jnyrup @cheenamalhotra
Improve EnclaveDiffieHellmanInfo.Size (#4346)
03090b9
@dependabot dependabot Bot mentioned this pull request Aug 1, 2026
Merged
This was referenced Sep 18, 2026
Merged
Merged
Merged
This was referenced Nov 11, 2026
Merged
Open
Open
Closed
Closed
Closed
Open
Open
Closed
Merged
Merged
Open
Closed
Merged
Open
Merged
Open
Open
Closed
Closed
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes
@paulmedynski paulmedynski paulmedynski approved these changes

Assignees

@cheenamalhotra cheenamalhotra

@paulmedynski paulmedynski

Labels

None yet

Projects

SqlClient Board
Status: Done

Milestone

7.1.0-preview2

Development

Successfully merging this pull request may close these issues.

3 participants

@jnyrup @paulmedynski @cheenamalhotra