Visitar URL original
Pin Microsoft.SqlServer.Server package version to 1.0.0 by priyankatiwari08 · Pull Request #4434 · dotnet/SqlClient · GitHub
Skip to content

Pin Microsoft.SqlServer.Server package version to 1.0.0 - #4434

Merged
cheenamalhotra merged 1 commit into
mainfrom
dev/prtiwar/pin-sqlserver-1.0.0
Jul 8, 2026
Merged

cheenamalhotra merged 1 commit into
mainfrom
dev/prtiwar/pin-sqlserver-1.0.0

Conversation

@priyankatiwari08

@priyankatiwari08 priyankatiwari08 commented Jul 8, 2026 •

Copy link
Copy Markdown
Contributor

MDS release builds were pulling '1.0.0-preview1.' as the SqlServer sibling package version via -p:PackageVersionSqlServer, which does not exist on the internal feed and breaks 'Restore SqlServer package' during MDS pack. Also aligns the Versions.props fallback (SqlServerVersionDefault) so a build without the pipeline override still resolves to a shipping version.

Verification through non-official pipeline: https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=159853&view=results

MDS release builds were pulling '1.0.0-preview1.<buildNumber>' as the SqlServer sibling package version via -p:PackageVersionSqlServer, which does not exist on the internal feed and breaks 'Restore SqlServer package' during MDS pack. Also aligns the Versions.props fallback (SqlServerVersionDefault) so a build without the pipeline override still resolves to a shipping version.
@priyankatiwari08
priyankatiwari08 requested a review from a team as a code owner July 8, 2026 19:32
Copilot AI review requested due to automatic review settings July 8, 2026 19:32
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Jul 8, 2026
@priyankatiwari08 priyankatiwari08 added this to the 7.1.0-preview2 milestone Jul 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Microsoft.SqlServer.Server package version inputs so OneBranch builds and local fallback versioning consistently resolve to the shipping 1.0.0 package, avoiding restores for a non-existent preview build version during SqlClient packaging.

Changes:

  • Set SqlServerVersionDefault fallback to 1.0.0 in Microsoft.SqlServer.Server versioning props.
  • Pin OneBranch sqlServerPackageVersion to 1.0.0 regardless of isPreview to prevent restore failures.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Microsoft.SqlServer.Server/Versions.props Aligns default/fallback SqlServer package version to the shipping 1.0.0.
eng/pipelines/onebranch/variables/package-variables.yml Forces OneBranch sqlServerPackageVersion to 1.0.0 to avoid restoring a preview version that isn’t available.

@cheenamalhotra

Copy link
Copy Markdown
Member

Let's fast-track merging this PR - need not wait for tests completion since non-Official is already verified. @benrr101 @mdaigle

@cheenamalhotra
cheenamalhotra enabled auto-merge (squash) July 8, 2026 19:57
@cheenamalhotra
cheenamalhotra merged commit 90dda56 into main Jul 8, 2026
214 of 358 checks passed
@cheenamalhotra
cheenamalhotra deleted the dev/prtiwar/pin-sqlserver-1.0.0 branch July 8, 2026 20:31
@github-project-automation github-project-automation Bot moved this from To triage to Done in SqlClient Board Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants