Validate localized authentication resources in Abstractions builds - #4942

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.28%. Comparing base (dfa1967) to head (609b0cd).
⚠️ Report is 8 commits behind head on main.

@@            Coverage Diff             @@
##             main    #4942      +/-   ##
==========================================
- Coverage   73.95%   69.28%   -4.67%     
==========================================
  Files         314      314              
  Lines       45849    69742   +23893     
==========================================
+ Hits        33907    48320   +14413     
- Misses      11942    21422    +9480     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Looks good overall!

Note: I would not call this AOT or use this term in this PR to avoid confusions btw, since its unrelated to AOT support. Therefore, this is not a blocker for 8.0.0-preview1 release.

Two additional optional review suggestions:

• Allowlist naming: AllowedEnglishValueMatches and AbstractionsAllowedEnglishValueMatches are asymmetric and may scale poorly as more assemblies are added. A nested shape such as { "SqlClient": {...}, "Abstractions": {...} } could be cleaner.
• Test coverage: The first test verifies that the Abstractions section does not borrow the driver allowlist, but not the reverse. Consider asserting that the same resources fail when run with the driver section containing UnrelatedDriverKey.

Review-body feedback

• Fixed — Korean package identifier: Restored Microsoft.Data.SqlClient.Extensions.Azure and repaired the surrounding sentence in src/Microsoft.Data.SqlClient/src/Resources/Strings.ko.resx:598.
• Fixed — Traditional Chinese package identifier: Restored Microsoft.Data.SqlClient.Extensions.Azure and repaired the surrounding sentence in src/Microsoft.Data.SqlClient/src/Resources/Strings.zh-Hant.resx:598.
• Fixed — Portuguese tracing identifier: Restored the exact case-sensitive Microsoft.Data.SqlClient.EventSource name in src/Microsoft.Data.SqlClient/src/Resources/Strings.pt-BR.resx:598.

These three corrections are pushed in f096358. Their earlier resolved thread state did not establish that the current head contained the fixes.

• Already Addressed — Czech, German, and Italian WAM package references: The WAM upgrade messages cited in the older reviews are no longer present in the current Abstractions resource set. No further edit was made for those three superseded findings.
• Blocked — missing Abstractions translations: Strict validation still fails: each of the 13 satellite files lacks the same nine neutral-resource keys. All 14 Abstractions resource files are unchanged from the PR base. The strict gate was retained; translations remain pending. Report-only mode correctly reports SucceededWithIssues, not a localization pass.
• Already Addressed — OneBranch restore evidence: Historical build 187118 successfully ran Authenticate NuGet feeds, restored and built PackageValidator, and validated packages. The build log explicitly records the restore and successful build. This is historical evidence, not a OneBranch run of the current head.
• Informational — trusted review-policy references: For this feedback-resolution run, the author explicitly authorized immutable base dfa196743b3601e9c30d345728201da2d76dd44c as the policy source. Applicable guidance was read from that revision. This does not claim that earlier automated reviews completed their missing policy checks or that a new full-PR compliance review was performed.

Discussion-comment feedback

The three suggestions in #4942 (comment) were already addressed before this run:

• Already Addressed — AOT framing: The current PR title and description describe localization validation rather than an AOT support feature.
• Already Addressed — allowlist naming: Commit 99ad8eb783341721deb435ae1cf901c8152bbe3a provides symmetric SqlClient and Abstractions owner sections in .config/LocalizationValidationAllowlist.jsonc.
• Already Addressed — reverse isolation coverage: The existing independent-allowlist test explicitly asserts that selecting SqlClient rejects UnrelatedDriverKey while selecting Abstractions succeeds.

Validation

• Localization and pipeline-invocation Pester suites: 44 passed, 0 failed, 0 skipped.
• Exact technical identifiers and format-placeholder checks: passed for all three corrected messages; the same checks detect the original defects.
• Driver localization: passed, 13 satellites, 704 neutral keys, 76 approved English matches.
• Abstractions strict localization: failed, pending translations as described above; report-only behavior verified.
• git diff --check: passed.

All review bodies and discussion comments were inspected. No suppressed-findings block was present in any of the seven Copilot reviews. The author’s schema explanation was left open and unchanged; the Codecov status post required no reply.