Visitar URL original
[7.0.4 Cherry-pick] Fix managed SNI MARS receive teardown race by github-actions[bot] · Pull Request #4950 · dotnet/SqlClient · GitHub
Skip to content

[7.0.4 Cherry-pick] Fix managed SNI MARS receive teardown race - #4950

Merged
cheenamalhotra merged 2 commits into
release/7.0from
dev/automation/pr-4680-to-7.0.4
Nov 6, 2026
Merged

cheenamalhotra merged 2 commits into
release/7.0from
dev/automation/pr-4680-to-7.0.4

Conversation

@github-actions

Copy link
Copy Markdown

Cherry-pick of #4680 (266a32e) into release/7.0.

* Fix managed SNI MARS receive teardown race

Handle disposed TCP and named-pipe streams through SNI errors and preserve MARS packet ownership during receive re-arm failure. Add deterministic and SQL-backed regression coverage for #4679.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Fix MARS teardown callbacks and regression test hangs

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Address MARS teardown review feedback

Keep consumed-packet cleanup outside the receive lock, add a lock-scope regression, and remove redundant manual-test collection isolation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added this to the 7.0.4 milestone Oct 30, 2026
@github-actions
github-actions Bot requested a review from a team as a code owner October 30, 2026 17:53
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Oct 30, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@cheenamalhotra

Copy link
Copy Markdown
Member

/azp run

@cheenamalhotra cheenamalhotra moved this from To triage to In review in SqlClient Board Oct 30, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).
1 pipeline(s) were filtered out due to trigger conditions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@cheenamalhotra

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).
1 pipeline(s) were filtered out due to trigger conditions.

@codecov

codecov Bot commented Nov 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.71%. Comparing base (4745f32) to head (a998aa9).
⚠️ Report is 4 commits behind head on release/7.0.

❗ There is a different number of reports uploaded between BASE (4745f32) and HEAD (a998aa9). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (4745f32) HEAD (a998aa9)
CI-SqlClient 1 0
Additional details and impacted files
@@               Coverage Diff               @@
##           release/7.0    #4950      +/-   ##
===============================================
- Coverage        73.13%   66.71%   -6.42%     
===============================================
  Files              281      291      +10     
  Lines            43433    66352   +22919     
===============================================
+ Hits             31764    44270   +12506     
- Misses           11669    22082   +10413     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 66.71% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants