Visitar URL original
Add Windows disk I/O metrics to ResourceMonitoring by makazeu · Pull Request #6181 · dotnet/extensions · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
555b98e
create an empty file for WindowsDiskMetrics
makazeu Mar 23, 2025
2e8a9be
Implement Windows Disk I/O bytes metric
makazeu Mar 23, 2025
fe0c09b
update
makazeu Mar 23, 2025
664053a
Add SupportedOSPlatform attribute for Windows in disk metrics classes
makazeu Mar 23, 2025
3180f66
update
makazeu Mar 23, 2025
ccb3d27
Fix property name for disk I/O metrics enabling in Windows
makazeu Mar 23, 2025
24e60bd
update
makazeu Mar 23, 2025
f6957fe
Improve error handling in disk performance counter initialization
makazeu Mar 23, 2025
07ceca6
Rename disk performance counter classes
makazeu Mar 23, 2025
9e12912
Implement Disk Operations metric
makazeu Mar 23, 2025
37c9e8a
Style updates
makazeu Mar 24, 2025
8bba5a4
Add PlatformAttributes in LegacySupport
makazeu Mar 24, 2025
878e61b
Add a simple unit test
makazeu Mar 24, 2025
e9985af
Add interfaces for PerformanceCounter
makazeu Mar 24, 2025
6d96e50
update ut
makazeu Mar 24, 2025
6095dd0
Merge branch 'main' into windows-disk-metrics
makazeu Mar 24, 2025
718bc13
Use TimeProvider
makazeu Mar 25, 2025
db2949a
Add TimeProvider as a singleton in ResourceMonitoringServiceCollectio…
makazeu Mar 25, 2025
12edc8a
Add unit tests for PerformanceCounterFactory and PerformanceCounterWr…
makazeu Mar 25, 2025
23a0f3d
update
makazeu Mar 25, 2025
6c108da
Add Unit Tests
makazeu Mar 25, 2025
080ae7d
Refine
makazeu Mar 25, 2025
a3efed7
Refine
makazeu Mar 26, 2025
7053f3f
Refine
makazeu Mar 26, 2025
93ea836
Add WindowsDiskMetricsTests
makazeu Mar 26, 2025
54836ec
Refine
makazeu Mar 26, 2025
a1b620e
Merge branch 'main' into windows-disk-metrics
makazeu Mar 29, 2025
a1de91a
clean
makazeu Mar 29, 2025
a0395c0
Refine
makazeu Mar 29, 2025
c0fbc4d
Merge branch 'main' into windows-disk-metrics
makazeu Apr 24, 2025
d9d9194
Merge branch 'dotnet:main' into windows-disk-metrics
makazeu Apr 27, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix property name for disk I/O metrics enabling in Windows
  • Loading branch information
makazeu committed Mar 23, 2025
commit ccb3d271017f9c9c50a4baa71c85b13b2b63a9f6
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ public partial class ResourceMonitoringOptions
/// Gets or sets a value indicating whether disk I/O metrics should be enabled.
/// </summary>
[Experimental(diagnosticId: DiagnosticIds.Experiments.ResourceMonitoring, UrlFormat = DiagnosticIds.UrlFormat)]
public bool EnabledDiskIoMetrics { get; set; }
public bool EnableDiskIoMetrics { get; set; }
Comment thread
makazeu marked this conversation as resolved.
Resolved
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ internal sealed class WindowsDiskMetrics

public WindowsDiskMetrics(IMeterFactory meterFactory, IOptions<ResourceMonitoringOptions> options)
{
if (!options.Value.EnabledDiskIoMetrics)
if (!options.Value.EnableDiskIoMetrics)
{
return;
}
Expand Down