Visitar URL original
Refactor Resource Monitoring by evgenyfedorov2 · Pull Request #6554 · dotnet/extensions · GitHub
Skip to content

Refactor Resource Monitoring - #6554

Merged
evgenyfedorov2 merged 10 commits into
dotnet:mainfrom
evgenyfedorov2:users/evgenyfedorov2/refactor_linux_cgroup_options
Jul 3, 2025
Merged

Refactor Resource Monitoring#6554
evgenyfedorov2 merged 10 commits into
dotnet:mainfrom
evgenyfedorov2:users/evgenyfedorov2/refactor_linux_cgroup_options

Conversation

@evgenyfedorov2

@evgenyfedorov2 evgenyfedorov2 commented Jun 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Member
  1. Rename CalculateCpuUsageWithoutHostDelta to UseLinuxCpuUsageV2.
  2. Remove UseDeltaNrPeriodsForCpuCalculation option and merge its logic with UseLinuxCpuUsageV2.
  3. Remove debug logs and metrics.
  4. Minor code massaging.
Microsoft Reviewers: Open in CodeFlow

@evgenyfedorov2
evgenyfedorov2 force-pushed the users/evgenyfedorov2/refactor_linux_cgroup_options branch 2 times, most recently from 07b5619 to 54a0b83 Compare June 30, 2025 09:43
evgenyfedorov2
Fix tests
4e16fae 
Update CompatibilitySuppressions
Remove unnecessary logging and metrics
Rename CalculateCpuUsageWithoutHostDelta to UseLinuxCpuUsageV2
Remove UseDeltaNrPeriosForCpuCalculaton
@evgenyfedorov2
evgenyfedorov2 force-pushed the users/evgenyfedorov2/refactor_linux_cgroup_options branch from 54a0b83 to 4e16fae Compare June 30, 2025 10:09
@evgenyfedorov2
evgenyfedorov2 marked this pull request as ready for review June 30, 2025 11:04
@evgenyfedorov2
evgenyfedorov2 requested review from a team as code owners June 30, 2025 11:04
@evgenyfedorov2

evgenyfedorov2 commented Jun 30, 2025

Copy link
Copy Markdown
Member Author

@nivebb8 do you want to review this? We are removing debug logs, metrics, and adjusting code to use only one boolean flag instead of two.

amadeuszl
amadeuszl reviewed Jul 1, 2025
View reviewed changes
Comment thread ...raries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationProvider.cs Resolved
Comment thread src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/ResourceMonitoringOptions.cs Resolved
Comment thread ...raries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationProvider.cs Resolved
Comment thread .../Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring.Tests/Linux/AcceptanceTest.cs Resolved
Comment thread ...raries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationProvider.cs Resolved
nivebb8
nivebb8 reviewed Jul 2, 2025
View reviewed changes
Comment thread src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/ResourceMonitoringOptions.cs Resolved
evgenyfedorov2 added 2 commits July 3, 2025 07:04
evgenyfedorov2
Merge branch 'main' into users/evgenyfedorov2/refactor_linux_cgroup_o…
86cd0a0 
…ptions

# Conflicts:
#	src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/CompatibilitySuppressions.xml
evgenyfedorov2
Fix suppressions
6a57a63
@evgenyfedorov2
evgenyfedorov2 enabled auto-merge (squash) July 3, 2025 05:08
evgenyfedorov2
Revert "Fix suppressions"
9b1b7eb 
This reverts commit 6a57a63.
@evgenyfedorov2
evgenyfedorov2 merged commit 95a6013 into dotnet:main Jul 3, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amadeuszl amadeuszl amadeuszl approved these changes
+1 more reviewer
@nivebb8 nivebb8 nivebb8 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@evgenyfedorov2 evgenyfedorov2

Labels

area-telemetry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evgenyfedorov2 @amadeuszl @nivebb8