Visitar URL original
HttpDependencyMetadataResolver class for the custom downstream dependency metadata resolution by rainsxng · Pull Request #6880 · dotnet/extensions · GitHub
Skip to content

HttpDependencyMetadataResolver class for the custom downstream dependency metadata resolution - #6880

Merged
rainsxng merged 21 commits into
mainfrom
dbohdanov/metadata-resolver-api
Nov 6, 2025
Merged

HttpDependencyMetadataResolver class for the custom downstream dependency metadata resolution#6880
rainsxng merged 21 commits into
mainfrom
dbohdanov/metadata-resolver-api

Conversation

@rainsxng

@rainsxng rainsxng commented Oct 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

As per following API proposal, this PR exposes the DownstreamDependencyMetadataManager class with the new name that allows you to configure the downstream dependency metadata resolution and brings more flexibility into the flow

Microsoft Reviewers: Open in CodeFlow

@rainsxng rainsxng changed the title new metadata resolver api HttpDependencyMetadataResolver class for the custom downstream dependency metadata resolution Oct 22, 2025
@rainsxng
rainsxng marked this pull request as ready for review October 22, 2025 15:19
@rainsxng
rainsxng requested a review from a team as a code owner October 22, 2025 15:19
Copilot AI review requested due to automatic review settings October 22, 2025 15:19
Copilot AI reviewed Oct 22, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the downstream dependency metadata resolution system by introducing a new public API HttpDependencyMetadataResolver to replace the internal IDownstreamDependencyMetadataManager interface. The changes expose the dependency metadata resolution functionality with improved naming and flexibility.

  • Renames internal DownstreamDependencyMetadataManager to public HttpDependencyMetadataResolver as an abstract class
  • Adds DefaultHttpDependencyMetadataResolver as the default implementation
  • Updates registration methods to use TryAddEnumerable for proper DI behavior with multiple metadata instances

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
HttpDependencyMetadataResolver.cs Converts internal sealed class to public abstract class with documentation and removes obsolete HttpWebRequest support
DefaultHttpDependencyMetadataResolver.cs New sealed class providing default implementation of the resolver
HttpDiagnosticsServiceCollectionExtensions.cs Updates registration to use TryAddEnumerable and adds new AddStandardHttpDependencyMetadataResolver method
HttpRequestReader.cs Updates field and parameter names to use new resolver type
IDownstreamDependencyMetadataManager.cs Marks internal interface as obsolete
DownstreamDependencyMetadataManagerTests.cs Updates test class to use new resolver type and namespace

Comment thread src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/HttpDependencyMetadataResolver.cs Resolved
Comment thread ...ies/Microsoft.Extensions.Http.Diagnostics/Http/HttpDiagnosticsServiceCollectionExtensions.cs Resolved
Comment thread ...ies/Microsoft.Extensions.Http.Diagnostics/Http/HttpDiagnosticsServiceCollectionExtensions.cs Resolved
dariusclay
dariusclay reviewed Oct 29, 2025
View reviewed changes
Comment thread ...ies/Microsoft.Extensions.Http.Diagnostics/Http/HttpDiagnosticsServiceCollectionExtensions.cs Resolved
evgenyfedorov2
evgenyfedorov2 requested changes Oct 29, 2025
View reviewed changes
Comment thread src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/HttpDependencyMetadataResolver.cs Resolved
Comment thread src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/HttpDependencyMetadataResolver.cs Resolved
Comment thread ...crosoft.Extensions.Http.Diagnostics/Logging/Internal/IDownstreamDependencyMetadataManager.cs Resolved
Comment thread ...ibraries/Microsoft.Extensions.Http.Diagnostics/Http/DefaultHttpDependencyMetadataResolver.cs Resolved
Comment thread ...ies/Microsoft.Extensions.Http.Diagnostics/Http/HttpDiagnosticsServiceCollectionExtensions.cs Resolved
evgenyfedorov2
evgenyfedorov2 approved these changes Nov 3, 2025
View reviewed changes
Comment thread ...ibraries/Microsoft.Extensions.Http.Diagnostics/Http/DefaultHttpDependencyMetadataResolver.cs Resolved
@rainsxng
rainsxng enabled auto-merge (squash) November 6, 2025 14:19
@rainsxng
rainsxng merged commit b839e41 into main Nov 6, 2025
@rainsxng
rainsxng deleted the dbohdanov/metadata-resolver-api branch November 6, 2025 14:55
@rainsxng rainsxng mentioned this pull request Nov 10, 2025
Closed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dariusclay dariusclay dariusclay approved these changes
@evgenyfedorov2 evgenyfedorov2 evgenyfedorov2 approved these changes

Assignees

@rainsxng rainsxng

Labels

area-telemetry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rainsxng @dariusclay @evgenyfedorov2