Visitar URL original
Improve release-manager workflow and validation guidance by jeffhandley · Pull Request #7848 · dotnet/extensions · GitHub
Skip to content

Improve release-manager workflow and validation guidance - #7848

Merged
jeffhandley merged 2 commits into
mainfrom
jeffhandley/10-11-release-manager-retrospective
Nov 2, 2026
Merged

Improve release-manager workflow and validation guidance#7848
jeffhandley merged 2 commits into
mainfrom
jeffhandley/10-11-release-manager-retrospective

Conversation

@jeffhandley

@jeffhandley jeffhandley commented Oct 15, 2026 •
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Member

Summary

  • Add a canonical Mermaid workflow and proactive guided checkpoints with scoped approvals and explicit exceptions.
  • Guard release month/version selection, public branch baselines, and build/nuspec/tag SHA provenance.
  • Clarify retry safety, artifact/feed handling, worktree handoffs, release notes, and website follow-up.
  • Check every library TFM's original Portable PDB identity and nonempty Source Link mappings before publishing; retain JSON diagnostics and return failure exits.
  • Reflow changed Markdown prose for lighter diffs; no MEAI console harness is included.

Validation

  • 28 offline Pester tests passed with compiled PDB fixtures and mocked external operations.
  • Independent read-only checks recognized known-good 10.10.0 and empty-metadata 10.11.0 PDBs.
  • Markdown links/anchors, workflow dependencies/routing, maintenance-only scope, and diff checks passed.
  • Formatting preserves prose tokens, Markdown structure, encoding, and line endings.

No live release operations were performed; this does not repair published PDBs or establish their regression's cause.

Microsoft Reviewers: Open in CodeFlow

@jeffhandley
Improve release-manager workflow and validation guidance
637cefa 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a384205-396b-4fb7-9a56-b689ce59557e
@jeffhandley
jeffhandley requested a review from a team as a code owner October 15, 2026 09:20
Copilot AI balanced review requested due to automatic review settings October 15, 2026 09:20
Copilot AI reviewed Oct 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Source Link validation correctness, tool discovery, JSON output, and Pester compatibility issues remain unresolved.

5 open findings
What changed in this PR

Strengthens release-manager guidance across preparation, publication, validation, and release notes.

Changes:

  • Defines shared workflow checkpoints, scoped approvals, and provenance requirements.
  • Adds per-TFM Portable PDB and Source Link validation with JSON diagnostics and offline tests.
  • Clarifies reconciliation, retries, package scope, and release follow-up.
File Description
.github/​agents/​release-manager/​write-release-notes/​references/​format-template.md Clarifies monthly version exceptions.
.github/​agents/​release-manager/​write-release-notes/​references/​experimental-features.md Grounds API claims in shipped evidence.
.github/​agents/​release-manager/​write-release-notes/​references/​editorial-rules.md Requires verified attribution.
.github/​agents/​release-manager/​write-release-notes/​references/​collect-prs.md Uses shipped-source evidence for inclusion.
.github/​agents/​release-manager/​write-release-notes/​README.md Adds manifest and tag provenance gates.
.github/​agents/​release-manager/​validate-release/​scripts/​Test-SourceLink.Tests.ps1 Adds offline validation coverage.
.github/​agents/​release-manager/​validate-release/​scripts/​Test-SourceLink.ps1 Implements per-asset checks and reporting.
.github/​agents/​release-manager/​validate-release/​references/​stage-7-support-page.md Clarifies website ownership and deployment checks.
.github/​agents/​release-manager/​validate-release/​references/​stage-6-reconcile-branches.md Pins reconciliation identities and cleanup.
.github/​agents/​release-manager/​validate-release/​references/​stage-5-verify-source-link.md Separates metadata and public-source validation.
.github/​agents/​release-manager/​validate-release/​README.md Updates validation sequencing and closeout.
.github/​agents/​release-manager/​references/​workflow.md Defines canonical workflow and approvals.
.github/​agents/​release-manager/​references/​package-scope-and-dependency-validation.md Strengthens manifest and dependency requirements.
.github/​agents/​release-manager/​references/​candidate-validation.md Defines build and artifact evidence gates.
.github/​agents/​release-manager/​publish-release/​references/​stage-4-publish-and-promote.md Adds prepublication checks and retry guidance.
.github/​agents/​release-manager/​publish-release/​references/​stage-3-build-servicing.md Requires pinned builds and explicit test policy.
.github/​agents/​release-manager/​publish-release/​references/​stage-3-build-monthly.md Separates build, landing, and queue approvals.
.github/​agents/​release-manager/​publish-release/​README.md Introduces the prepublication metadata gate.
.github/​agents/​release-manager/​prepare-release/​references/​stages-1-2-servicing-branch.md Adds servicing version and approval safeguards.
.github/​agents/​release-manager/​prepare-release/​references/​stage-2-update-dependencies.md Defines version guards and dependency ownership.
.github/​agents/​release-manager/​prepare-release/​references/​stage-1-prepare-internal-branch.md Locates actual restore authentication boundaries.
.github/​agents/​release-manager/​prepare-release/​README.md Adds baseline capture and manual product versioning.
.github/​agents/​release-manager.agent.md Aligns agent behavior with shared workflow.

🧠 Review effort: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/agents/release-manager/validate-release/scripts/Test-SourceLink.Tests.ps1 Resolved
Comment thread .github/agents/release-manager/validate-release/scripts/Test-SourceLink.ps1 Resolved
Comment thread .github/agents/release-manager/validate-release/scripts/Test-SourceLink.ps1 Resolved
Comment thread .github/agents/release-manager/validate-release/scripts/Test-SourceLink.ps1 Resolved
Comment thread .github/agents/release-manager/validate-release/scripts/Test-SourceLink.ps1 Resolved
@jeffhandley
Fix Source Link validation review findings
a556bbb 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5a384205-396b-4fb7-9a56-b689ce59557e
adamsitnik
adamsitnik approved these changes Nov 2, 2026
View reviewed changes

@adamsitnik adamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for making it more explicit and less error prone @jeffhandley !

Comment thread .github/agents/release-manager/prepare-release/references/stage-2-update-dependencies.md Resolved
Comment thread .github/agents/release-manager/prepare-release/references/stage-2-update-dependencies.md Resolved
@jeffhandley
jeffhandley merged commit 47dd770 into main Nov 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@adamsitnik adamsitnik adamsitnik approved these changes

Assignees

@jeffhandley jeffhandley

Labels

area-infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeffhandley @adamsitnik