Visitar URL original
Publish ILVerify actual baselines on CI failure by T-Gro · Pull Request #20585 · dotnet/fsharp · GitHub
Skip to content

Publish ILVerify actual baselines on CI failure - #20585

Merged
T-Gro merged 2 commits into
mainfrom
idea/dm-920
Sep 25, 2026
Merged

T-Gro merged 2 commits into
mainfrom
idea/dm-920

Conversation

@T-Gro

@T-Gro T-Gro commented Sep 18, 2026

Copy link
Copy Markdown
Member

Publish generated ILVerify actual baselines as downloadable CI artifacts when verification fails, so contributors can inspect and update baselines without reproducing the failure locally.

Stage only immediate actual baseline files after a failed ILVerify job, then publish the attempt-specific directory only after all copies succeed. Keep verifier failure semantics unchanged and make both diagnostic tasks non-blocking.

Validation: recorded RED with exact producer output and missing collector wiring; GREEN has 17 helper plus 13 artifact tests passing with Pester 3.4.0. Clean local-core Release solution build passed. Broader Release tests remain red: two closure newobj assertions and an SDK test missing net472 props; no compiler or baseline changes made. Azure upload was not executed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added the AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed label Sep 18, 2026
@github-project-automation github-project-automation Bot moved this from New to In Progress in F# Compiler and Tooling Sep 22, 2026
@T-Gro
T-Gro merged commit c593bdb into main Sep 25, 2026
54 checks passed
@T-Gro
T-Gro deleted the idea/dm-920 branch September 25, 2026 08:24
bartelink pushed a commit to bartelink/fsharp that referenced this pull request Oct 7, 2026
* Publish ILVerify actual baselines on CI failure

Stage only immediate actual baseline files after a failed ILVerify job, then publish the attempt-specific directory only after all copies succeed. Keep verifier failure semantics unchanged and make both diagnostic tasks non-blocking.

Validation: recorded RED with exact producer output and missing collector wiring; GREEN has 17 helper plus 13 artifact tests passing with Pester 3.4.0. Clean local-core Release solution build passed. Broader Release tests remain red: two closure newobj assertions and an SDK test missing net472 props; no compiler or baseline changes made. Azure upload was not executed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add release notes

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
abonie added a commit to abonie/fsharp that referenced this pull request Nov 9, 2026
Backport the pipeline artifact publishing and its regression tests from dotnet#20585. Keep verifier failures unchanged and diagnostic collection and publishing non-blocking.

Source-commit: c593bdb

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3ea3661e-bfd2-4eab-ae53-dffca4d40576
abonie added a commit that referenced this pull request Nov 11, 2026
* Update cryptography dependency to 10.0.13 (#20783)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d8b637c2-ce3f-47e0-bf7f-ea6809e16eb6
Backport-of: 6c79b63
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3ea3661e-bfd2-4eab-ae53-dffca4d40576

* Update MessagePack package version to 2.5.303 (#20854)

Backport-of: fe180de
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3ea3661e-bfd2-4eab-ae53-dffca4d40576

* Update .NET SDK to unblock NativeAOT restore (#20929)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 490c9e24-6626-47cf-a24a-266fc29bd1d2
Backport-of: 23950a9
Copilot-Session: 3ea3661e-bfd2-4eab-ae53-dffca4d40576

* Adapt floating-point conversion tests for .NET 11 (#20400)

Backport the numeric-conversion test adaptations from #20400, retaining older-runtime expectations.

Source-commit: 0b2dec7

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3ea3661e-bfd2-4eab-ae53-dffca4d40576

* Publish ILVerify actual baselines on CI failure (#20585)

Backport the pipeline artifact publishing and its regression tests from #20585. Keep verifier failures unchanged and diagnostic collection and publishing non-blocking.

Source-commit: c593bdb

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3ea3661e-bfd2-4eab-ae53-dffca4d40576

* Adapt String completion expectations for .NET 11 (#20400)

Backport the remaining EditorTests.fs compatibility hunk from #20400. Include ToLowerOrdinal and ToUpperOrdinal only for .NET 11 and newer, preserving older-framework completion expectations.

Source-commit: 0b2dec7

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3ea3661e-bfd2-4eab-ae53-dffca4d40576

* Bump servicing package versions after publication

Advance the shared build number to 102 for FSharp.Core 11.0.102 and FSharp.Compiler.Service 43.13.102.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3ea3661e-bfd2-4eab-ae53-dffca4d40576

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d8b637c2-ce3f-47e0-bf7f-ea6809e16eb6
Copilot-Session: 3ea3661e-bfd2-4eab-ae53-dffca4d40576
Copilot-Session: 490c9e24-6626-47cf-a24a-266fc29bd1d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants