Visitar URL original
Run existing integration tests against published packages by matouskozak · Pull Request #7833 · dotnet/machinelearning · GitHub
Skip to content

Run existing integration tests against published packages - #7833

Merged
rosebyte merged 6 commits into
mainfrom
matouskozak-package-integration-review
Nov 4, 2026
Merged

rosebyte merged 6 commits into
mainfrom
matouskozak-package-integration-review

Conversation

@matouskozak

@matouskozak matouskozak commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Run the existing nightly test project against exact packages from a selected official build, using isolated build outputs and a fresh NuGet cache.

The improved probing exposes existing Linux failures. Temporarily quarantine TensorFlow image-classification training on Linux x64 (#7836) and the two affected SymSGD tests on Linux ARM32 (#7837). Other tests and platforms retain their coverage.

Missing native dependencies fail on supported platforms instead of silently skipping tests. Adds local usage instructions. CI configuration is unchanged.

This should eventually run inside a nightly CI pipeline which is not enabled at the moment. We can use this now as is, for local validation of packs before publishing to nuget.

matouskozak and others added 3 commits October 21, 2026 12:04
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d3b5b85b-5090-47e5-858b-86af0e7f73ff
Clarify that the diagnostics folder is local-only.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d3b5b85b-5090-47e5-858b-86af0e7f73ff
@matouskozak
matouskozak force-pushed the matouskozak-package-integration-review branch from bbc21d4 to 100af58 Compare October 21, 2026 11:05
@matouskozak
matouskozak marked this pull request as ready for review October 21, 2026 11:11
@matouskozak
matouskozak requested review from svick and a balanced review from Copilot and removed request for svick October 21, 2026 11:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Authenticated artifact resolution, isolated package restoration, and cross-platform native loading need end-to-end validation before approval.

No open issues 🎉

What changed in this PR

Enables local validation of published ML.NET packages using the existing nightly integration suite, without building ML.NET from source or changing CI configuration.

Changes:

  • Resolves exact package versions from a selected official build and runs tests with isolated outputs and a fresh NuGet cache.
  • Adds native package checks, LightGBM coverage, and updated capability detection.
  • Documents the local workflow and prerequisites.
File Description
test/​TestFrameworkDependency.props Imports selected versions for test helpers.
test/​NightlyBuildDependency.props Imports selected versions for nightly tests.
test/​Microsoft.ML.TestFrameworkCommon/​Utility/​NativeLibrary.cs Uses assembly-aware native loading on modern .NET.
test/​Microsoft.ML.TestFrameworkCommon/​Attributes/​FieldAwareFactorizationMachineFactAttribute.cs Recognizes AVX support when determining test eligibility.
test/​Microsoft.ML.NightlyBuild.Tests/​PackageNativeDependenciesTests.cs Verifies packaged ONNX and MKL native libraries load.
test/​Microsoft.ML.NightlyBuild.Tests/​Microsoft.ML.NightlyBuild.Tests.csproj Configures package-only testing without repository-native copying.
test/​Microsoft.ML.IntegrationTests/​Evaluation.cs Adds a LightGBM training and evaluation test.
eng/​testing/​Run-PackageIntegrationTests.ps1 Runs isolated tests and retains diagnostics.
eng/​testing/​Resolve-PublishedPackages.ps1 Resolves package identities from official build manifests.
docs/​project-docs/​release-process.md Documents local package integration testing.

Review effort: Balanced

@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.79%. Comparing base (53e0fc6) to head (78d1e13).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...t/Microsoft.ML.TensorFlow.Tests/TensorflowTests.cs 66.66% 0 Missing and 1 partial ⚠️
...tes/FieldAwareFactorizationMachineFactAttribute.cs 50.00% 0 Missing and 1 partial ⚠️
...sts/TrainerEstimators/SymSgdClassificationTests.cs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7833      +/-   ##
==========================================
- Coverage   70.81%   70.79%   -0.02%     
==========================================
  Files        1421     1421              
  Lines      280010   279987      -23     
  Branches    27620    27620              
==========================================
- Hits       198281   198210      -71     
- Misses      73562    73635      +73     
+ Partials     8167     8142      -25     
Flag Coverage Δ
Debug 70.79% <81.25%> (-0.02%) ⬇️
production 64.27% <ø> (+0.02%) ⬆️
test 90.62% <81.25%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ft.ML.TestFrameworkCommon/Utility/NativeLibrary.cs 21.27% <100.00%> (-31.67%) ⬇️
...t/Microsoft.ML.TensorFlow.Tests/TensorflowTests.cs 91.79% <66.66%> (-0.06%) ⬇️
...tes/FieldAwareFactorizationMachineFactAttribute.cs 75.00% <50.00%> (-25.00%) ⬇️
...sts/TrainerEstimators/SymSgdClassificationTests.cs 97.43% <66.66%> (-2.57%) ⬇️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

matouskozak and others added 2 commits October 21, 2026 14:03
Track the affected TensorFlow and ARM32 SymSGD configurations in #7836 and #7837.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d3b5b85b-5090-47e5-858b-86af0e7f73ff
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d3b5b85b-5090-47e5-858b-86af0e7f73ff
Track the affected configurations in #7836 and #7837.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d3b5b85b-5090-47e5-858b-86af0e7f73ff
@matouskozak
matouskozak marked this pull request as ready for review October 21, 2026 18:20
@rosebyte
rosebyte merged commit 361de3a into main Nov 4, 2026
28 checks passed
@matouskozak
matouskozak deleted the matouskozak-package-integration-review branch November 10, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants