Visitar URL original
Option to avoid "fixing" \ in new TaskItem() by maridematte · Pull Request #11120 · dotnet/msbuild · GitHub
Skip to content

Option to avoid "fixing" \ in new TaskItem() - #11120

Merged
maridematte merged 7 commits into
dotnet:mainfrom
maridematte:11083
Dec 13, 2024
Merged

Option to avoid "fixing" \ in new TaskItem() #11120
maridematte merged 7 commits into
dotnet:mainfrom
maridematte:11083

Conversation

@maridematte

@maridematte maridematte commented Dec 10, 2024

Copy link
Copy Markdown
Member

Fixes #11083

Context

Sometimes TaskItems are not file paths, and we currently treat all of them as file paths and try to fix backslashes into slashes.

Changes Made

Added an option where TaskItems can be created without a reference to a path, and it will not try to fix it.

jeffkl
jeffkl reviewed Dec 10, 2024
View reviewed changes
Comment thread src/Utilities/TaskItem.cs Resolved
Comment thread src/Utilities/TaskItem.cs Resolved
Comment thread src/Utilities/TaskItem.cs Resolved
JanKrivanek
JanKrivanek approved these changes Dec 11, 2024
View reviewed changes

@JanKrivanek JanKrivanek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Let's get rid of default param

Comment thread src/Utilities/TaskItem.cs Resolved
@maridematte
maridematte requested a review from jeffkl December 13, 2024 14:11
rainersigwald
rainersigwald reviewed Dec 13, 2024
View reviewed changes
Comment thread src/Utilities/TaskItem.cs Resolved
Comment thread src/Utilities/TaskItem.cs Resolved
Comment thread src/Utilities/TaskItem.cs Resolved
@maridematte
maridematte enabled auto-merge (squash) December 13, 2024 15:51
@maridematte
maridematte merged commit 8c0edd2 into dotnet:main Dec 13, 2024
@maridematte
maridematte deleted the 11083 branch March 10, 2025 15:05
This was referenced Jul 28, 2025
Closed
Merged
Closed
Closed
Closed
Closed
Open
Open
Closed
This was referenced Aug 4, 2025
Closed
Closed
Open
Closed
Open
@dependabot dependabot Bot mentioned this pull request Aug 15, 2025
Closed
This was referenced Aug 29, 2026
Closed
Closed
Merged
Open
Closed
Closed
Closed
Closed
Closed
Merged
This was referenced Sep 6, 2026
Closed
Merged
This was referenced Sep 21, 2026
Open
Merged
@dependabot dependabot Bot mentioned this pull request Sep 29, 2026
Merged
This was referenced Oct 10, 2026
Closed
Closed
This was referenced Oct 21, 2026
Open
Merged
Closed
Closed
This was referenced Oct 31, 2026
Closed
Merged
Closed
This was referenced Nov 7, 2026
Closed
Open
Open
Open
Open
@dependabot dependabot Bot mentioned this pull request Nov 14, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes
@JanKrivanek JanKrivanek JanKrivanek approved these changes
@jeffkl jeffkl Awaiting requested review from jeffkl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Option to avoid "fixing" \ in new TaskItem()

4 participants

@maridematte @rainersigwald @JanKrivanek @jeffkl