Visitar URL original
Include links to nuget by EamonNerbonne · Pull Request #258 · dotnet/reactive · GitHub
Skip to content

Include links to nuget - #258

Merged
clairernovotny merged 1 commit into
dotnet:masterfrom
EamonNerbonne:patch-1
Aug 12, 2016
Merged

clairernovotny merged 1 commit into
dotnet:masterfrom
EamonNerbonne:patch-1

Conversation

@EamonNerbonne

Copy link
Copy Markdown
Contributor

Just in case I'm not the only one that was confused as I was in #242: link to nuget package page from package name.

Just in case I'm not the only one that was confused as I was in dotnet#242: link to nuget package page from package name.
@dnfclas

dnfclas commented Aug 12, 2016

Copy link
Copy Markdown

Hi @EamonNerbonne, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@EamonNerbonne

Copy link
Copy Markdown
Contributor Author

If this kind of change is welcome and wanted: I think it might also be clearer to rephrase the "breaking change" section from the perspective of the present. I.e. name the section "Nuget packages" with a bold "breaking change" in the section body rather than title, and list the current package names before the packages they replace.

@clairernovotny

Copy link
Copy Markdown
Contributor

Thanks!

@clairernovotny
clairernovotny merged commit da139dd into dotnet:master Aug 12, 2016
@dnfclas

dnfclas commented Aug 12, 2016

Copy link
Copy Markdown

Hi @EamonNerbonne, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants