Visitar URL original
Implement `IAlternateEqualityComparer<ReadOnlySpan<char>, string>` on `EqualityComparer<string>.Default` by stephentoub · Pull Request #104202 · dotnet/runtime · GitHub
Skip to content

Implement IAlternateEqualityComparer<ReadOnlySpan<char>, string> on EqualityComparer<string>.Default - #104202

Merged
stephentoub merged 5 commits into
dotnet:mainfrom
stephentoub:equalitycomparerdefaultalternate
Jul 2, 2024
Merged

Implement IAlternateEqualityComparer<ReadOnlySpan<char>, string> on EqualityComparer<string>.Default#104202
stephentoub merged 5 commits into
dotnet:mainfrom
stephentoub:equalitycomparerdefaultalternate

Conversation

@stephentoub

@stephentoub stephentoub commented Jun 30, 2024

Copy link
Copy Markdown
Member

Fixes #102906

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 30, 2024
@stephentoub
stephentoub force-pushed the equalitycomparerdefaultalternate branch 2 times, most recently from 69a192b to b627e2c Compare June 30, 2024 03:32
jkotas
jkotas reviewed Jun 30, 2024
View reviewed changes
Comment thread src/libraries/System.Private.CoreLib/src/System/Collections/Generic/EqualityComparer.cs Resolved
@build-analysis build-analysis Bot mentioned this pull request Jun 30, 2024
Closed
MichalPetryka
MichalPetryka reviewed Jun 30, 2024
View reviewed changes
Comment thread src/libraries/System.Private.CoreLib/src/System/Collections/Generic/EqualityComparer.cs Resolved
Comment thread src/coreclr/vm/jitinterface.cpp Resolved
jkotas
jkotas reviewed Jun 30, 2024
View reviewed changes
Comment thread src/coreclr/vm/jitinterface.cpp Resolved
jkotas
jkotas reviewed Jun 30, 2024
View reviewed changes
Comment thread src/coreclr/vm/jitinterface.cpp Resolved
@stephentoub
stephentoub force-pushed the equalitycomparerdefaultalternate branch from 894ce80 to a6e4488 Compare July 1, 2024 02:49
@jkotas jkotas added area-System.Collections and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 1, 2024
This was referenced Jul 1, 2024
Open
Open
Closed
eiriktsarpalis
eiriktsarpalis reviewed Jul 1, 2024
View reviewed changes
Comment thread ...raries/System.Collections.Concurrent/tests/ConcurrentDictionary/ConcurrentDictionaryTests.cs Resolved
@stephentoub
stephentoub marked this pull request as ready for review July 1, 2024 13:56
@stephentoub
stephentoub force-pushed the equalitycomparerdefaultalternate branch from 5b1ec8f to d13131e Compare July 1, 2024 13:56
eiriktsarpalis
eiriktsarpalis reviewed Jul 1, 2024
View reviewed changes

@eiriktsarpalis eiriktsarpalis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing lots of build errors, but they appear to be infra related?

@build-analysis build-analysis Bot mentioned this pull request Jul 1, 2024
Open
@stephentoub stephentoub mentioned this pull request Jul 1, 2024
Merged
tannergooding
tannergooding approved these changes Jul 1, 2024
View reviewed changes

@tannergooding tannergooding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managed side changes LGTM.

@stephentoub stephentoub closed this Jul 1, 2024
@stephentoub stephentoub reopened this Jul 1, 2024
@build-analysis build-analysis Bot mentioned this pull request Jul 1, 2024
Closed
@jkotas

jkotas commented Jul 1, 2024

Copy link
Copy Markdown
Member

/azp run runtime-nativeaot-outerloop

@azure-pipelines

azure-pipelines Bot commented Jul 1, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

jkotas
jkotas approved these changes Jul 1, 2024
View reviewed changes

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once the naot test run passed with no failures related to this change)

@build-analysis build-analysis Bot mentioned this pull request Jul 1, 2024
Closed
@jkotas jkotas mentioned this pull request Jul 1, 2024
Closed
@stephentoub stephentoub mentioned this pull request Jul 2, 2024
Open
@stephentoub
stephentoub merged commit aa280ad into dotnet:main Jul 2, 2024
@stephentoub
stephentoub deleted the equalitycomparerdefaultalternate branch July 2, 2024 01:39
@jkotas jkotas mentioned this pull request Jul 3, 2024
Closed
@matouskozak matouskozak mentioned this pull request Jul 9, 2024
Closed
@LoopedBard3

LoopedBard3 commented Jul 9, 2024

Copy link
Copy Markdown
Member

Improvements:
Linux x64: dotnet/perf-autofiling-issues#37870
Windows x64: dotnet/perf-autofiling-issues#37858, dotnet/perf-autofiling-issues#37822

@lewing lewing mentioned this pull request Jul 9, 2024
Open
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes
@jkotas jkotas jkotas approved these changes
@tannergooding tannergooding tannergooding approved these changes
@marek-safar marek-safar Awaiting requested review from marek-safar
@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner
+1 more reviewer
@MichalPetryka MichalPetryka MichalPetryka left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@stephentoub stephentoub

Labels

area-System.Collections

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement IAlternateEqualityComparer<ReadOnlySpan<char>, string> on EqualityComparer<string>.Default

6 participants

@stephentoub @jkotas @LoopedBard3 @eiriktsarpalis @tannergooding @MichalPetryka