Visitar URL original
Clarify async validation XML documentation by ViveliDuCh · Pull Request #135410 · dotnet/runtime · GitHub
Skip to content

Clarify async validation XML documentation - #135410

Merged
ViveliDuCh merged 2 commits into
mainfrom
docs/async-validation-xml-comments
Oct 9, 2026
Merged

Clarify async validation XML documentation#135410
ViveliDuCh merged 2 commits into
mainfrom
docs/async-validation-xml-comments

Conversation

@ViveliDuCh

@ViveliDuCh ViveliDuCh commented Oct 8, 2026

Copy link
Copy Markdown
Member

Summary

  • clarify synchronous fallback, dispatch, cancellation, exception, and concurrency guidance for asynchronous DataAnnotations validation
  • document asynchronous Options validator registration, dispatch, startup validation, and synchronous-access behavior
  • complete the DataAnnotations-to-Options bridge and options validation source-generator XML documentation

This is a documentation-only change. The DataAnnotations updates keep the runtime source comments aligned with dotnet/dotnet-api-docs#13101, while the Microsoft.Extensions.Options comments are source-owned and flow through the normal API-reference import process.

Related to #131498.

Testing

  • baseline build.cmd -subset libs
  • built System.ComponentModel.Annotations, Microsoft.Extensions.Options, and Microsoft.Extensions.Options.DataAnnotations
  • passed System.ComponentModel.Annotations.Tests (1,008 tests)
  • passed Microsoft.Extensions.Options.Tests for both target runs
  • passed Options source-generation tests and source-generation unit tests (one conditionally skipped test)

@ViveliDuCh
Clarify async validation XML documentation
a9daf03 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: ab284f39-5590-450a-acee-4f3f9d76e52e
@azure-pipelines

azure-pipelines Bot commented Oct 8, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

dotnet-policy-service Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-componentmodel-dataannotations
See info in area-owners.md if you want to be subscribed.

Youssef1313
Youssef1313 reviewed Oct 8, 2026
View reviewed changes
Comment thread ...ries/Microsoft.Extensions.Options.DataAnnotations/src/DataAnnotationValidateOptions.Async.cs Outdated
Youssef1313
Youssef1313 reviewed Oct 8, 2026
View reviewed changes
Comment thread .../Microsoft.Extensions.Options.DataAnnotations/src/OptionsBuilderDataAnnotationsExtensions.cs Outdated
This was referenced Oct 8, 2026
Open
Open
tarekgh
tarekgh reviewed Oct 8, 2026
View reviewed changes
Comment thread src/libraries/Microsoft.Extensions.Options/src/OptionsBuilder.cs Outdated
tarekgh
tarekgh reviewed Oct 8, 2026
View reviewed changes
Comment thread ...ies/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/Validator.cs Outdated
tarekgh
tarekgh reviewed Oct 8, 2026
View reviewed changes
Comment thread src/libraries/Microsoft.Extensions.Options/src/IAsyncValidateOptions.cs Outdated
tarekgh
tarekgh reviewed Oct 8, 2026
View reviewed changes
Comment thread ...onentModel.Annotations/src/System/ComponentModel/DataAnnotations/AsyncValidationAttribute.cs
tarekgh
tarekgh approved these changes Oct 8, 2026
View reviewed changes

@tarekgh tarekgh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@ViveliDuCh

ViveliDuCh commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

/ba-g Unrelated failure already being tracked in #133208

@ViveliDuCh ViveliDuCh mentioned this pull request Oct 9, 2026
Open
@ViveliDuCh
ViveliDuCh merged commit 6539c4b into main Oct 9, 2026
86 of 88 checks passed
@ViveliDuCh
ViveliDuCh deleted the docs/async-validation-xml-comments branch October 9, 2026 19:05
@ViveliDuCh

ViveliDuCh commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

/backport to release/11.0

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Started backporting to release/11.0 (link to workflow run)

@github-actions github-actions Bot mentioned this pull request Oct 9, 2026
Merged
2 of 4 tasks
ViveliDuCh added a commit that referenced this pull request Oct 9, 2026
@github-actions @ViveliDuCh
[release/11.0] Clarify async validation XML documentation (#135536)
2d69c4c 
Backport of #135410 to release/11.0

/cc @ViveliDuCh

## Customer Impact

- [ ] Customer reported
- [x] Found internally

Adds API documentation guidance for the new .NET 11 asynchronous
validation feature.

## Regression

- [ ] Yes
- [x] No

Documentation update for a new feature.

## Testing

Documentation-only change already validated in #135410.

## Risk

Low; API documentation only, with no runtime behavior or API shape
changes.

Co-authored-by: Viviana Dueñas <50237907+ViveliDuCh@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: ab284f39-5590-450a-acee-4f3f9d76e52e
@dotnet-maestro dotnet-maestro Bot mentioned this pull request Oct 12, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarekgh tarekgh tarekgh approved these changes
@Youssef1313 Youssef1313 Youssef1313 approved these changes
@danroth27 danroth27 Awaiting requested review from danroth27

Assignees

@ViveliDuCh ViveliDuCh

Labels

area-System.ComponentModel.DataAnnotations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ViveliDuCh @tarekgh @Youssef1313