Repository navigation
Allow CI scanner shell built-ins and extend inactivity watchdog - #135417
Draft
vitek-karas wants to merge 1 commit into
Draft
vitek-karas wants to merge 1 commit into
vitek-karas wants to merge 1 commit into
Conversation
Allow the read and no-op Bash built-ins used by the scanner, and extend the inactivity watchdog so quiet log retrieval can continue after an early issue output. Regenerate the workflow with the existing pinned compiler. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 15 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Member
|
Thanks, this should fix permission issues. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change is needed
CI Outer-Loop Failure Scanner run 37487931212 fetched the build lists for all 36 pipelines, but could not execute its timeline-fetch command because
readwas missing from the Bash command allowlist. The agent usedwhile read -r buildto consume build IDs produced byjq; this is piped-data processing, not interactive input.Local Docker reproduction exposed two further obstacles: the agent also used Bash's
:no-op builtin in a loop, which was denied, and the default two-minute inactivity watchdog interrupted an active but quiet log-fetch command. That watchdog starts after the first issue output, even though the scanner may still have more failures to investigate. The interrupted run returned exit code 0, so its exit status alone did not establish that the scan completed.Changes
readand:builtins used by the observed scanner commands.Validation
git diff --checkFull end-to-end completion remains unverified. The last Docker scan was stopped after a defect in the local runner let it exceed its intended 90-minute deadline; some CI evidence was also unavailable. The local deadline handling was corrected separately and regression-tested, but that runner is not included in this patch. Docker validation exercised the agent job only, and no issues were published. The ad hoc validation scripts and fixtures are session-local, not part of this PR.
Note
This pull request description was prepared with GitHub Copilot.