Repository navigation
[browser][CoreCLR] Collect ReadyToRun PGO with indexed schemas - #137502
Draft
pavelsavara wants to merge 2 commits into
Draft
pavelsavara wants to merge 2 commits into
pavelsavara wants to merge 2 commits into
Conversation
Collect 64-bit IL block profiles through normal JIT instrumentation and preserve distinct intrinsic and interpreter invocation contributions. Resolve indexed R2R schemas to stable counter storage and carry the profiles through EventPipe, MIBC, and partial ReadyToRun consumption. Add publish configuration, schema and compiler regressions, browser round trips, and usage documentation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve legacy interpreter profiling outside single-threaded Browser, use per-method schema allocation chains, and handle sparse flow inference conservatively when exception exits are not measurable. Include the pending main merge and all local PGO fixes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Contributor
|
Tagging @dotnet/jit-contrib for JIT-EE GUID update |
Contributor
|
Tagging subscribers to this area: @dotnet/crossgen-contrib |
|
Azure Pipelines: Successfully started running 6 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable opt-in PGO collection from published Browser/CoreCLR ReadyToRun applications and consume the resulting MIBC in a subsequent optimized, partial ReadyToRun publish.
Design
PgoInstrumentationSchemasReadyToRun section and an indexedPgoInstrumentationDatafixup. Deterministic, deduplicated schemas describe instrumentation kinds, IL offsets, counts, and aligned byte offsets into counter storage. The ReadyToRun format becomes 34.1.Integration and scope
WasmPgoInstrumentation=allor a MethodSet filter through application and framework ReadyToRun publishing, independently of CPU sampling. Recompile framework images when instrumentation changes and invalidate the corresponding incremental stamps.DOTNET_WasmPgoInstrumentationfor ordinary interpreter collection through the same profiling infrastructure.Tracking: #130521.
Repository migration
Replaces dotnet/runtime#137491 so further work can use an upstream branch instead of a personal fork. The original PR retains its review discussion and historical validation details.
Upstream branch:
pavelsavara/browser-coreclr-r2r-pgo-schema-table. Copied commit:06fa85f1de97d2fb9d49281677436b6387aba9e0.The copied commit also includes the pending main merge and all local PGO fixes: legacy interpreter profiling outside single-threaded Browser is preserved, allocation lookup uses per-method schema chains, and sparse flow inference is conservative about unmeasured exception exits. Related regression tests and documentation are included.
Current validation: builds and tests were explicitly skipped at the user's request. The new merge and fixes have not been validated by this migration session.
Note
This PR description was generated with GitHub Copilot assistance.