Visitar URL original
Add shared project for .NET Framework polyfills by JeremyKuhne · Pull Request #14371 · dotnet/winforms · GitHub
Skip to content

Add shared project for .NET Framework polyfills - #14371

Merged
JeremyKuhne merged 10 commits into
dotnet:mainfrom
JeremyKuhne:polyfill
Mar 11, 2026
Merged

Add shared project for .NET Framework polyfills#14371
JeremyKuhne merged 10 commits into
dotnet:mainfrom
JeremyKuhne:polyfill

Conversation

@JeremyKuhne

@JeremyKuhne JeremyKuhne commented Mar 9, 2026 •
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Member

Adds static extensions to allow multitargetting our core assemblies so they can be used on .NET Framework.

This is part of work to facilitate using core utility functionality in internal scenarios where we need to also build for .NET Framework.

Microsoft Reviewers: Open in CodeFlow

@JeremyKuhne
Add shared project for .NET Framework polyfills
b5964c3 
Adds static extensions to allow multitargetting our core assemblies so they can be used on .NET Framework.

This is part of work to facilitate using core utility functionality in internal scenarios where we need to also build for .NET Framework.
@JeremyKuhne
JeremyKuhne requested a review from Shyam-Gupta March 9, 2026 19:35
@JeremyKuhne
JeremyKuhne requested a review from a team as a code owner March 9, 2026 19:35
@JeremyKuhne

JeremyKuhne commented Mar 10, 2026

Copy link
Copy Markdown
Member Author

Coverlet 6.0.0 has issues with the multi-targeting. Updating to 8.0.0 might fix the issues the CI was hitting. I'm letting CI run through iterations on this as reproducing this locally is painful (have to fire off a full build -test /p:Coverage=true) build and wait for it.

@codecov

codecov Bot commented Mar 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.17092%. Comparing base (c83a1bd) to head (9ad1a48).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #14371         +/-   ##
===================================================
- Coverage   77.31140%   77.17092%   -0.14049%     
===================================================
  Files           3265        3240         -25     
  Lines         644447      643092       -1355     
  Branches       47631       47570         -61     
===================================================
- Hits          498231      496280       -1951     
- Misses        142524      143123        +599     
+ Partials        3692        3689          -3
Flag Coverage Δ
Debug 77.17092% <ø> (-0.14049%) ⬇️
integration 19.13055% <ø> (+0.00943%) ⬆️
production 52.05091% <ø> (-0.22400%) ⬇️
test 97.42254% <ø> (+0.00337%) ⬆️
unit 49.40706% <ø> (-0.23412%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Shyam-Gupta
Shyam-Gupta reviewed Mar 10, 2026
View reviewed changes
Comment thread src/Microsoft.Private.Windows.Polyfills/Microsoft.Private.Windows.Polyfills.shproj Resolved
Shyam-Gupta
Shyam-Gupta previously approved these changes Mar 11, 2026
View reviewed changes

@Shyam-Gupta Shyam-Gupta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Shared a few nits. Thanks.

Comment thread src/Microsoft.Private.Windows.Polyfills/System/StringExtensions.cs Resolved
Comment thread src/Microsoft.Private.Windows.Polyfills/System/StringExtensions.cs Resolved
Comment thread src/Microsoft.Private.Windows.Polyfills/System/SpanExtensions.cs Resolved
Comment thread src/Microsoft.Private.Windows.Polyfills/System/ISpanFormattable.cs Resolved
@JeremyKuhne
JeremyKuhne merged commit f3422f9 into dotnet:main Mar 11, 2026
8 checks passed
@JeremyKuhne
JeremyKuhne deleted the polyfill branch March 11, 2026 17:16
@dotnet-maestro dotnet-maestro Bot mentioned this pull request Mar 24, 2026
Merged
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Shyam-Gupta Shyam-Gupta Shyam-Gupta approved these changes

Assignees

@JeremyKuhne JeremyKuhne

Labels

area-Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JeremyKuhne @Shyam-Gupta