Visitar URL original
Pin System.Formats.Nrbf and its transitive dependencies to 10.0.4 release for .NET Framework by Shyam-Gupta · Pull Request #14487 · dotnet/winforms · GitHub
Skip to content

Pin System.Formats.Nrbf and its transitive dependencies to 10.0.4 release for .NET Framework - #14487

Merged
Shyam-Gupta merged 1 commit into
mainfrom
dev/shgu/pkg
Apr 21, 2026
Merged

Shyam-Gupta merged 1 commit into
mainfrom
dev/shgu/pkg

Conversation

@Shyam-Gupta

@Shyam-Gupta Shyam-Gupta commented Apr 21, 2026 •

Copy link
Copy Markdown
Member

This change pins the runtime assemblies pulled in by the System.Formats.Nrbf reference to the 10.0.4 release for .NET Framework project Microsoft.Private.Windows.Core.csproj. This is required for consumption in Dev18 VS.

• System.Formats.Nrbf → 10.0.4
• System.Collections.Immutable → 10.0.4 (transitive, now explicitly referenced with PrivateAssets="all")
• System.Reflection.Metadata → 10.0.4 (transitive, now explicitly referenced with PrivateAssets="all")

Without these pins, restore was resolving the .NET 11 preview (11.0.0-preview.4.26215.121) for these packages.

Microsoft Reviewers: Open in CodeFlow

…rvicing on .NET Framework

In .NET 4.8.1 project Microsoft.Private.Windows.Core.csproj, pinning the runtime assemblies pulled in by the System.Formats.Nrbf reference to the 10.0.4 release. This is required for consumption in Dev18 VS.

• System.Formats.Nrbf → 10.0.4
• System.Collections.Immutable → 10.0.4 (transitive, now explicitly referenced with PrivateAssets="all")
• System.Reflection.Metadata → 10.0.4 (transitive, now explicitly referenced with PrivateAssets="all")

Without these pins, restore was resolving the .NET 11 preview (11.0.0-preview.4.26215.121) for these packages.
@Shyam-Gupta Shyam-Gupta self-assigned this Apr 21, 2026
@Shyam-Gupta
Shyam-Gupta requested a review from a team as a code owner April 21, 2026 19:39
@Shyam-Gupta
Shyam-Gupta enabled auto-merge April 21, 2026 20:17
@Shyam-Gupta
Shyam-Gupta merged commit 2f889a2 into main Apr 21, 2026
10 checks passed
@Shyam-Gupta
Shyam-Gupta deleted the dev/shgu/pkg branch April 21, 2026 20:24
@github-actions github-actions Bot locked and limited conversation to collaborators May 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants