Repository navigation
⬆️ Bump ty to 0.0.84 - #16452
Open
YuriiMotov wants to merge 6 commits into
Open
⬆️ Bump ty to 0.0.84#16452YuriiMotov wants to merge 6 commits into
YuriiMotov wants to merge 6 commits into
Conversation
YuriiMotov
added
dependencies
Contributor
📝 Docs previewLast commit 76c9e5d at: https://ebe45e51.fastapitiangolo.pages.dev |
YuriiMotov
commented
Oct 2, 2026
| parse_options_header, # noqa: F401 | ||
| ) | ||
|
|
||
| assert parse_options_header |
Member
Author
There was a problem hiding this comment.
As far as I understand these asserts were added just to suppress the "Unused import" warnings.
YuriiMotov
commented
Oct 2, 2026
| field_mapping=field_mapping, | ||
| separate_input_output_schemas=separate_input_output_schemas, | ||
| ) | ||
| if result: |
Member
Author
There was a problem hiding this comment.
A non-empty tuple is always evaluated to True. And get_openapi_path always returns a tuple with 3 dicts:
fastapi/fastapi/openapi/utils.py
Line 540 in 02912c3
YuriiMotov
commented
Oct 2, 2026
| "/simple_include", | ||
| response_model=Model2, | ||
| response_model_include={"baz": ..., "ref": {"foo"}}, | ||
| response_model_include={"baz": True, "ref": {"foo"}}, |
Member
Author
There was a problem hiding this comment.
As far as I understand it, old Pydantic docs recommended this syntax (with ...), but current version uses True: https://docs.pydantic.dev/latest/concepts/serialization/#excluding-and-including-specific-fields
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrading to the latest ty requires some changes. Added some inline review comments to clarify decisions
AI Disclaimer
Used Codex (Astra high) to investigate warnings and apply changes. Verified manually
Checklist