Visitar URL original
fix: Update java testcontainers to use Compose V2 by tokoko · Pull Request #4381 · feast-dev/feast · GitHub
Skip to content

fix: Update java testcontainers to use Compose V2 #4381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyary merged 2 commits into from
Aug 6, 2024
Merged

fix: Update java testcontainers to use Compose V2 #4381

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cbbba2
fix: revert java testcontainers to use docker-based compose
tokoko Aug 5, 2024
1e9cdaf
fix: update testcontainers-java to Compose v2
tokoko Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: revert java testcontainers to use docker-based compose 
Signed-off-by: tokoko <togurgenidze@gmail.com>
  • Loading branch information
@tokoko
tokoko committed Aug 5, 2024
commit 8cbbba28fcf80b210e184060d075774aa9483ed8
3 changes: 1 addition & 2 deletions java/serving/src/test/java/feast/serving/it/ServingEnvironment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,7 @@ static void globalSetup() {
.withExposedService("redis", 6379)
.withExposedService(
"feast", 8080, Wait.forListeningPort().withStartupTimeout(Duration.ofSeconds(180)))
.withTailChildContainers(true)
.withLocalCompose(true);
.withTailChildContainers(true);

environment.start();
}
Expand Down