Visitar URL original
perf: Make /push async by robhowley · Pull Request #4650 · feast-dev/feast · GitHub
Skip to content

perf: Make /push async #4650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 4 commits into from
Oct 21, 2024
Merged

perf: Make /push async #4650

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f415dc
add async push interface
robhowley Oct 18, 2024
e161177
add test to ensure only calling async when supported for the push mode
robhowley Oct 18, 2024
205046c
clean up
robhowley Oct 18, 2024
d172157
clean up test
robhowley Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean up 
Signed-off-by: Rob Howley <howley.robert@gmail.com>
  • Loading branch information
@robhowley
robhowley committed Oct 18, 2024
commit 205046ce1cedb277eb488dd0b2380b35494cc673
1 change: 0 additions & 1 deletion sdk/python/feast/feature_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,6 @@ async def push(body=Depends(get_body)):
and to in [PushMode.ONLINE, PushMode.ONLINE_AND_OFFLINE]
)
if should_push_async:
print("im in async?")
await store.push_async(**push_params)
else:
store.push(**push_params)
Comment on lines +211 to +218

@robhowley robhowley Oct 18, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if async writes to the online store are supported and the post body indicates that data will be written to the online store, then attempt an async storep.push

Expand Down