Visitar URL original
feat: Adding SSL support for online server by lokeshrangineni · Pull Request #4677 · feast-dev/feast · GitHub
Skip to content

feat: Adding SSL support for online server #4677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 4 commits into from
Oct 25, 2024
Merged

feat: Adding SSL support for online server #4677

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c054f9
* Adding the SSL support for online_server.
lokeshrangineni Oct 25, 2024
2b000ee
Incorporating code review comment.
lokeshrangineni Oct 25, 2024
f2482a9
Update docs/reference/feature-servers/python-feature-server.md
lokeshrangineni Oct 25, 2024
1ca37f3
* Update docs/reference/feature-servers/python-feature-server.md
lokeshrangineni Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
* Update docs/reference/feature-servers/python-feature-server.md 
* fixing the integration test failure.

Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
  • Loading branch information
@lokeshrangineni
lokeshrangineni committed Oct 25, 2024
commit 1ca37f3b1d47c25cce51130f62192022afcc410e
6 changes: 3 additions & 3 deletions sdk/python/tests/integration/online_store/test_remote_online_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,9 @@ def _overwrite_remote_client_feature_store_yaml(
ssl_cert_path: str = "",
):
repo_config = os.path.join(repo_path, "feature_store.yaml")
config_content = dedent(

config_content = "entity_key_serialization_version: 2\n" + auth_config
config_content += dedent(
f"""
project: {PROJECT_NAME}
registry: {registry_path}
Expand All @@ -242,7 +244,5 @@ def _overwrite_remote_client_feature_store_yaml(
if ssl_cert_path:

@franciscojavierarceo franciscojavierarceo Oct 25, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

config_content += f" ssl_cert_path: {ssl_cert_path}\n"

config_content += " entity_key_serialization_version: 2\n" + auth_config

with open(repo_config, "w") as repo_config_file:
repo_config_file.write(config_content)