mypy fixes; remove online source creator

Signed-off-by: Tomasz Wrona <tomasz@cast.ai>
franciscojavierarceo · Mar 12, 2025 · Oct 31, 2024 · Oct 31, 2024 · Oct 31, 2024 · Oct 31, 2024
commit 8207c44cd379eed772382b2d02601366fa7f86a0
@@ -382,21 +382,22 @@ def _arrow_to_ch_timestamp_type(t_str: str) -> str:
     unit = unit.strip()
     precision = _ARROW_PRECISION_TO_CH_PRECISION[unit]
 
-    tz: Optional[str] = None
     if len(rest):
-        tz: str = rest[0]
+        tz = rest[0]
         tz = (
             tz.strip()
             .removeprefix("tz=")
             .translate(
                 str.maketrans(
-                    {
+                    {  # type: ignore[arg-type]
                         "'": None,
                         '"': None,
                     }
                 )
             )
         )
+    else:
+        tz = None
 
     if precision > 0:
         if tz is not None:

@@ -173,9 +173,9 @@ def to_data_source(self) -> DataSource:
         return ClickhouseSource(table=self.clickhouse_options._table)
 
 
-def ch_type_to_feast_value_type(type_: str) -> ValueType:
-    type_obj = get_from_name(type_)
-    type_ = type(type_obj)
+def ch_type_to_feast_value_type(type_str: str) -> ValueType:
+    type_obj = get_from_name(type_str)
+    type_cls = type(type_obj)
     container_type = None
     if isinstance(type_obj, Array):
         container_type = Array
@@ -201,9 +201,9 @@ def ch_type_to_feast_value_type(type_: str) -> ValueType:
         (Array, DateTime): ValueType.UNIX_TIMESTAMP_LIST,
         (Array, DateTime64): ValueType.UNIX_TIMESTAMP_LIST,
     }
-    value = type_map.get((container_type, type_), ValueType.UNKNOWN)
+    value = type_map.get((container_type, type_cls), ValueType.UNKNOWN)
     if value == ValueType.UNKNOWN:
-        print("unknown type:", type_)
+        print("unknown type:", type_str)
     return value
 
 

@@ -16,14 +16,9 @@
     ClickhouseSource,
 )
 from feast.infra.utils.clickhouse.clickhouse_config import ClickhouseConfig
-from feast.infra.utils.clickhouse.connection_utils import get_client
-from feast.saved_dataset import SavedDatasetStorage
 from tests.integration.feature_repos.universal.data_source_creator import (
     DataSourceCreator,
 )
-from tests.integration.feature_repos.universal.online_store_creator import (
-    OnlineStoreCreator,
-)
 
 logger = logging.getLogger(__name__)
 
@@ -61,7 +56,7 @@ def clickhouse_container():
     container.stop()
 
 
-class ClickhouseDataSourceCreator(DataSourceCreator, OnlineStoreCreator):
+class ClickhouseDataSourceCreator(DataSourceCreator):
     def create_logged_features_destination(self) -> LoggingDestination:
         return None  # type: ignore
 
@@ -101,6 +96,8 @@ def create_data_source(
         destination_name = self.get_prefixed_table_name(destination_name)
 
         if self.offline_store_config:
+            if timestamp_field is None:
+                timestamp_field = "ts"
             df_to_clickhouse_table(
                 self.offline_store_config, df, destination_name, timestamp_field
             )
@@ -119,24 +116,8 @@ def create_offline_store_config(self) -> ClickhouseOfflineStoreConfig:
     def get_prefixed_table_name(self, suffix: str) -> str:
         return f"{self.project_name}_{suffix}"
 
-    def create_online_store(self) -> ClickhouseOnlineStoreConfig:
-        assert self.container
-
-        get_client(self.offline_store_config).command(
-            f"CREATE DATABASE {CLICKHOUSE_ONLINE_DB}"
-        )
-
-        return ClickhouseOnlineStoreConfig(
-            type="feast.infra.offline_stores.contrib.clickhouse_offline_store.clickhouse.ClickhouseOfflineStore",
-            host="localhost",
-            port=self.container.get_exposed_port(8123),
-            database=CLICKHOUSE_ONLINE_DB,
-            user=CLICKHOUSE_USER,
-            password=CLICKHOUSE_PASSWORD,
-        )
-
-    def create_saved_dataset_destination(self) -> SavedDatasetStorage:
-        return None
+    def create_saved_dataset_destination(self):
+        pass
 
     def teardown(self):
         pass
@@ -1,4 +1,4 @@
-from pydantic import StrictStr, ConfigDict
+from pydantic import ConfigDict, StrictStr
 
 from feast.repo_config import FeastConfigBaseModel