Visitar URL original
feat: Adding Milvus demo to examples by franciscojavierarceo · Pull Request #4910 · feast-dev/feast · GitHub
Skip to content

feat: Adding Milvus demo to examples #4910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 17 commits into from
Jan 30, 2025
Merged

feat: Adding Milvus demo to examples #4910

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
468368a
checking in progress but this Pr still is not ready yet
franciscojavierarceo Jan 25, 2025
8f26494
feat: Adding new method to FeatureStore to allow more flexible retrie…
franciscojavierarceo Jan 27, 2025
ddc963b
Adding requested_features back into online_store
franciscojavierarceo Jan 27, 2025
006e897
feat: Adding RAG demo displaying Milvus usage for RAG
franciscojavierarceo Jan 8, 2025
a1a9408
uploading sample data and updated yaml
franciscojavierarceo Jan 10, 2025
4fba66c
updating workflow
franciscojavierarceo Jan 10, 2025
c4736b7
updated example
franciscojavierarceo Jan 10, 2025
f7393a7
removing modified files
franciscojavierarceo Jan 10, 2025
d0a1e30
reverting postgres change
franciscojavierarceo Jan 10, 2025
0d4c351
updating test_workflow
franciscojavierarceo Jan 13, 2025
7c006b1
updated and fixed bug
franciscojavierarceo Jan 28, 2025
63aa43b
fixing a bad merge/rebase
franciscojavierarceo Jan 29, 2025
aa81350
updated linter because of latest nistall
franciscojavierarceo Jan 29, 2025
e2a1949
reverting feature store change
franciscojavierarceo Jan 29, 2025
017ff54
adding logging of local milvus back
franciscojavierarceo Jan 29, 2025
ac96e36
Updating readme and adding notebook
franciscojavierarceo Jan 29, 2025
c629a42
updated readme
franciscojavierarceo Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reverting feature store change 
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
  • Loading branch information
@franciscojavierarceo
franciscojavierarceo committed Jan 29, 2025
commit e2a19493a9119c9f8acd9a3f053fa12236a1b666
37 changes: 13 additions & 24 deletions sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1847,30 +1847,19 @@ def retrieve_online_documents(
join_key_values[join_key] = []
join_key_values[join_key].append(entity_value)

document_feature_vals = [feature[4] for feature in document_features]
document_feature_distance_vals = [
feature[5] for feature in document_features
]
online_features_response = GetOnlineFeaturesResponse(results=[])
requested_feature = requested_feature or requested_features[0]
utils._populate_result_rows_from_columnar(
online_features_response=online_features_response,
data={
**join_key_values,
requested_feature: document_feature_vals,
"distance": document_feature_distance_vals,
},
)
return OnlineResponse(online_features_response)
else:
return self._retrieve_from_online_store_v2(
provider,
requested_feature_view,
requested_features,
query,
top_k,
distance_metric,
)
document_feature_vals = [feature[4] for feature in document_features]
document_feature_distance_vals = [feature[5] for feature in document_features]
online_features_response = GetOnlineFeaturesResponse(results=[])
requested_feature = requested_feature or requested_features[0]
utils._populate_result_rows_from_columnar(
online_features_response=online_features_response,
data={
**join_key_values,
requested_feature: document_feature_vals,
"distance": document_feature_distance_vals,
},
)
return OnlineResponse(online_features_response)

def retrieve_online_documents_v2(
self,
Expand Down