Visitar URL original
feat: Enable users to use Entity Query as CTE during historical retrieval by blaketastic2 · Pull Request #5202 · feast-dev/feast · GitHub
Skip to content

feat: Enable users to use Entity Query as CTE during historical retrieval #5202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 6 commits into from
Apr 1, 2025
Merged

feat: Enable users to use Entity Query as CTE during historical retrieval #5202

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
41e3a5f
entity query as cte
blaketastic2 Mar 31, 2025
5b77838
formatting
blaketastic2 Mar 31, 2025
1dd7c08
backward compatible
blaketastic2 Mar 31, 2025
e0cf916
updated docs
blaketastic2 Mar 31, 2025
4376a7b
jinja2 template fix
blaketastic2 Apr 1, 2025
8892d5b
test data
blaketastic2 Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test data 
Signed-off-by: Blake <blaketastic2@gmail.com>
  • Loading branch information
@blaketastic2
blaketastic2 committed Apr 1, 2025
commit 8892d5b8d9a94ca27d02c4d480f9a0b398895d98
20 changes: 10 additions & 10 deletions sdk/python/tests/unit/infra/offline_stores/contrib/postgres_offline_store/test_postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import logging
from datetime import datetime
from datetime import datetime, timezone
from unittest.mock import MagicMock, patch

import pandas as pd
Expand Down Expand Up @@ -56,8 +56,8 @@ def test_pull_latest_from_table_with_nested_timestamp_or_query(mock_get_conn):
feature_name_columns = ["feature1", "feature2"]
timestamp_field = "event_header.event_published_datetime_utc"
created_timestamp_column = "created_timestamp"
start_date = datetime(2021, 1, 1)
end_date = datetime(2021, 1, 2)
start_date = datetime(2021, 1, 1, tzinfo=timezone.utc)
end_date = datetime(2021, 1, 2, tzinfo=timezone.utc)

# Call the method
retrieval_job = PostgreSQLOfflineStore.pull_latest_from_table_or_query(
Expand All @@ -81,7 +81,7 @@ def test_pull_latest_from_table_with_nested_timestamp_or_query(mock_get_conn):
SELECT a."key1", a."key2", a."feature1", a."feature2", a."event_header.event_published_datetime_utc", a."created_timestamp",
ROW_NUMBER() OVER(PARTITION BY a."key1", a."key2" ORDER BY a."event_header.event_published_datetime_utc" DESC, a."created_timestamp" DESC) AS _feast_row
FROM offline_store_database_name.offline_store_table_name a
WHERE a."event_header.event_published_datetime_utc" BETWEEN '2021-01-01 00:00:00'::timestamptz AND '2021-01-02 00:00:00'::timestamptz
WHERE a."event_header.event_published_datetime_utc" BETWEEN '2021-01-01 00:00:00+00:00'::timestamptz AND '2021-01-02 00:00:00+00:00'::timestamptz
) b
WHERE _feast_row = 1""" # noqa: W293

Expand Down Expand Up @@ -123,8 +123,8 @@ def test_pull_latest_from_table_without_nested_timestamp_or_query(mock_get_conn)
feature_name_columns = ["feature1", "feature2"]
timestamp_field = "event_published_datetime_utc"
created_timestamp_column = "created_timestamp"
start_date = datetime(2021, 1, 1)
end_date = datetime(2021, 1, 2)
start_date = datetime(2021, 1, 1, tzinfo=timezone.utc)
end_date = datetime(2021, 1, 2, tzinfo=timezone.utc)

# Call the method
retrieval_job = PostgreSQLOfflineStore.pull_latest_from_table_or_query(
Expand All @@ -148,7 +148,7 @@ def test_pull_latest_from_table_without_nested_timestamp_or_query(mock_get_conn)
SELECT a."key1", a."key2", a."feature1", a."feature2", a."event_published_datetime_utc", a."created_timestamp",
ROW_NUMBER() OVER(PARTITION BY a."key1", a."key2" ORDER BY a."event_published_datetime_utc" DESC, a."created_timestamp" DESC) AS _feast_row
FROM offline_store_database_name.offline_store_table_name a
WHERE a."event_published_datetime_utc" BETWEEN '2021-01-01 00:00:00'::timestamptz AND '2021-01-02 00:00:00'::timestamptz
WHERE a."event_published_datetime_utc" BETWEEN '2021-01-01 00:00:00+00:00'::timestamptz AND '2021-01-02 00:00:00+00:00'::timestamptz
) b
WHERE _feast_row = 1""" # noqa: W293

Expand Down Expand Up @@ -189,8 +189,8 @@ def test_pull_all_from_table_or_query(mock_get_conn):
join_key_columns = ["key1", "key2"]
feature_name_columns = ["feature1", "feature2"]
timestamp_field = "event_published_datetime_utc"
start_date = datetime(2021, 1, 1)
end_date = datetime(2021, 1, 2)
start_date = datetime(2021, 1, 1, tzinfo=timezone.utc)
end_date = datetime(2021, 1, 2, tzinfo=timezone.utc)

# Call the method
retrieval_job = PostgreSQLOfflineStore.pull_all_from_table_or_query(
Expand All @@ -208,7 +208,7 @@ def test_pull_all_from_table_or_query(mock_get_conn):

expected_query = """SELECT key1, key2, feature1, feature2, event_published_datetime_utc
FROM offline_store_database_name.offline_store_table_name AS paftoq_alias
WHERE "event_published_datetime_utc" BETWEEN '2021-01-01 05:00:00+00:00'::timestamptz AND '2021-01-02 05:00:00+00:00'::timestamptz""" # noqa: W293
WHERE "event_published_datetime_utc" BETWEEN '2021-01-01 00:00:00+00:00'::timestamptz AND '2021-01-02 00:00:00+00:00'::timestamptz""" # noqa: W293

logger.debug("Expected query:\n%s", expected_query)

Expand Down