Visitar URL original
feat: Added global search api and necessary unit tests by aniketpalu · Pull Request #5532 · feast-dev/feast · GitHub
Skip to content

feat: Added global search api and necessary unit tests - #5532

Merged
ntkathole merged 18 commits into
feast-dev:masterfrom
aniketpalu:feature/global-search
Aug 14, 2025
Merged

feat: Added global search api and necessary unit tests#5532
ntkathole merged 18 commits into
feast-dev:masterfrom
aniketpalu:feature/global-search

Conversation

@aniketpalu

@aniketpalu aniketpalu commented Jul 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR implements a comprehensive search API endpoint (GET /search) for Feast Feature Store that enables searching across all resource types (entities, feature views, feature services, data sources, saved datasets, permissions, projects).
Key features:

  • Multi-project search with optional project filtering
  • Resource type filtering with validation
  • Tag-based search and filtering (key:value format)
  • Fuzzy matching with relevance scoring
  • Flexible sorting by match score, name, or type
  • Strict parameter validation with HTTP 422 errors for invalid inputs
  • Graceful handling of non-existent projects/resources with warnings
  • The API accepts a mandatory query parameter and optional parameters for projects, tags, pagination and sorting. It includes robust error handling that validates all inputs, logs warnings for invalid parameters.

This addresses the need for a unified search interface that allows users and applications to efficiently discover Feast resources across multiple projects through a RESTful API, replacing the need for multiple separate API calls to find resources.

Which issue(s) this PR fixes:

Fixes RHOAIENG-27693

Misc

@aniketpalu
feat: Added global search api and necessary unit tests
3a4d2a9 
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu
Minor refactoring
006ef69 
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu
aniketpalu requested a review from a team as a code owner July 22, 2025 17:51
jyejare
jyejare reviewed Jul 23, 2025
View reviewed changes

@jyejare jyejare left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part 1 review done, Tests are yet to be reviewed.

Comment thread sdk/python/feast/api/registry/rest/search.py Outdated
Comment thread sdk/python/feast/api/registry/rest/search.py Outdated
Comment thread sdk/python/feast/api/registry/rest/search.py Outdated
Comment thread sdk/python/feast/api/registry/rest/search.py Outdated
Comment thread sdk/python/feast/api/registry/rest/search.py Outdated
Comment thread sdk/python/feast/api/registry/rest/search.py Outdated
Comment thread sdk/python/feast/api/registry/rest/search.py Outdated
Comment thread sdk/python/feast/api/registry/rest/search.py Outdated
@aniketpalu
Addressed comments, create re-usable function to get all resources, r…
3b44f55 
…emoved unnecessary filtering logic for global search api

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@ntkathole

ntkathole commented Jul 29, 2025

Copy link
Copy Markdown
Member

@aniketpalu Please rebase and add documentation of search api in https://github.com/feast-dev/feast/blob/master/docs/reference/feature-servers/registry-server.md

@aniketpalu
Rebased due to updated upstream
808d126 
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu
Re-usable & modular dependency functions, removal of unnecessary fiel…
3c71804 
…ds, updated & added test cases, documentation update

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu
Minor refactoring & optimzations
cfa32b1 
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu
Minor reformatting, optimized unit tests to do more comprehensive tests
35db91d 
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu
Fixed minor linting error
8be2e6f 
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
jyejare
jyejare requested changes Aug 1, 2025
View reviewed changes

@jyejare jyejare left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending comments !

Comment thread docs/reference/feature-servers/registry-server.md
Comment thread docs/reference/feature-servers/registry-server.md Outdated
Comment thread sdk/python/feast/api/registry/rest/rest_utils.py
Comment thread sdk/python/feast/api/registry/rest/rest_utils.py Outdated
Comment thread sdk/python/feast/api/registry/rest/rest_utils.py Outdated
Comment thread sdk/python/tests/unit/api/test_search_api.py Outdated
Comment thread sdk/python/tests/unit/api/test_search_api.py Outdated
Comment thread sdk/python/tests/unit/api/test_search_api.py Outdated
Comment thread sdk/python/tests/unit/api/test_search_api.py Outdated
Comment thread sdk/python/tests/unit/api/test_search_api.py Outdated
aniketpalu and others added 10 commits August 8, 2025 02:58
@aniketpalu
Merge branch 'feast-dev:master' into feature/global-search
24cd526
@aniketpalu
Optimized Code, better error handling, created reusable functions and…
b353317 
… combined test cases

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu
Minor formatting & type lints related changes
0765720 
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu
Merge branch 'feast-dev:master' into feature/global-search
3dda05a
@aniketpalu
Added exact similarity score in response, updated docs
33a5292 
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu
Minor reformatting & fixed lint error
c5a6791 
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu
Conflicts resolved
81204d9 
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu
Added onDemandFeatureView test cases, minor function naming changes a…
20c34e8 
…nd increased fuzzy match threshold

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu
Merge remote-tracking branch 'origin/master' into feature/global-search
9ab68db
@aniketpalu
Minor code change after rebase
214e13c 
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
ntkathole
ntkathole approved these changes Aug 14, 2025
View reviewed changes

@ntkathole ntkathole left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ntkathole
ntkathole merged commit dd3061f into feast-dev:master Aug 14, 2025
franciscojavierarceo pushed a commit that referenced this pull request Aug 14, 2025
@feast-ci-bot
chore(release): release 0.52.0
acb97fb 
# [0.52.0](v0.51.0...v0.52.0) (2025-08-14)

### Bug Fixes

* Correct entity value type mapping for aliased feature views ([#5492](#5492)) ([bdf20bb](bdf20bb))
* Correct namespace reference in remote Feast project setup for operator upgrade and previous version tests ([df391ec](df391ec))
* dell pydantic v1 ([1189512](1189512))
* Fixed the entity to on-demand feature view relationship ([1c59bba](1c59bba))
* Make transformers optional ([#5544](#5544)) ([a4eef38](a4eef38))
* Push Source inherits the timestamp fields from Data Source ([#5550](#5550)) ([b7ea5cc](b7ea5cc))
* Remove the devcontainer folder. ([a9815c2](a9815c2))

### Features

* Added API for discovering Feature Views by popular tags ([#5558](#5558)) ([2e5f564](2e5f564))
* Added filtering support for featureView and featureServices api ([#5552](#5552)) ([897b3f3](897b3f3))
* Added global search api and necessary unit tests ([#5532](#5532)) ([dd3061f](dd3061f))
* Added Ray Compute Engine and Ray Offline Store Support ([#5526](#5526)) ([72de088](72de088))
* Added recent visit logging api for registry server ([#5545](#5545)) ([2adcf2c](2adcf2c))
* **auth:** support client-credentials & static token for OIDC client auth ([fc44222](fc44222))
* **auth:** support client-credentials & static token for OIDC client auth ([795fc06](795fc06))
* Implement and enhance remote document retrieval functionality ([#5487](#5487)) ([d095b96](d095b96))
* Implemented consistent error handling ([7f10151](7f10151))
* Offline Store historical features retrieval without entity df, but based on datatime range ([#5527](#5527)) ([df942b9](df942b9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jyejare jyejare jyejare approved these changes
@ntkathole ntkathole ntkathole approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aniketpalu @ntkathole @jyejare