Visitar URL original
feat: Add UUID and TIME_UUID as feature types (#5885) by soooojinlee · Pull Request #5951 · feast-dev/feast · GitHub
Skip to content

feat: Add UUID and TIME_UUID as feature types (#5885) #5951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 15 commits into from
Apr 1, 2026
Merged

feat: Add UUID and TIME_UUID as feature types (#5885) #5951

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6991f44
feat: Add UUID and TIME_UUID as feature types (#5885)
soooojinlee Feb 8, 2026
55065f2
test: Add unit tests for UUID type support
soooojinlee Feb 8, 2026
53c2513
style: Fix ruff lint and formatting issues
soooojinlee Feb 8, 2026
678dc72
feat: Add dedicated UUID/TIME_UUID proto fields to Value.proto
soooojinlee Feb 8, 2026
8e15939
fix: Address review feedback for UUID type support
soooojinlee Feb 8, 2026
a098c3c
fix: Address review feedback for UUID type support
soooojinlee Feb 8, 2026
6c9ba63
fix: Address review feedback
soooojinlee Feb 8, 2026
ac7a61d
fix: Convert uuid.UUID to string for Arrow and JSON serialization
soooojinlee Feb 12, 2026
fe0bfb2
feat: Add UUID_SET/TIME_UUID_SET support and update type system docs
soooojinlee Feb 17, 2026
732088a
fix: Preserve PDF_BYTES/IMAGE_BYTES enum values and add missing SET t…
soooojinlee Feb 17, 2026
5d637c5
fix: Correct misleading comment in Set.__init__
soooojinlee Feb 17, 2026
e4b0a86
refactor: Extract UUID Arrow conversion into helper and move import t…
soooojinlee Feb 18, 2026
b9b15d2
fix: Handle UUID types in _proto_value_to_transport_value for JSON se…
soooojinlee Mar 7, 2026
3c07e12
chore: Regenerate protobuf files with UUID type support
soooojinlee Mar 27, 2026
7b600cb
fix: Fix mypy type ignore comments for UUID collection conversions
soooojinlee Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Address review feedback for UUID type support 
Signed-off-by: soojin <soojin@dable.io>
  • Loading branch information
@soooojinlee @ntkathole
soooojinlee authored and ntkathole committed Apr 1, 2026
commit a098c3c808c0ebf9d6562a5cb036946e83377956
6 changes: 4 additions & 2 deletions sdk/python/feast/on_demand_feature_view.py
View file
Open in desktop
Comment thread
soooojinlee marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -1164,8 +1164,8 @@ def _get_sample_values_by_type(self) -> dict[ValueType, list[Any]]:
ValueType.PDF_BYTES: [pdf_sample],
ValueType.IMAGE_BYTES: [image_sample],
# UUID types
ValueType.UUID: [str(uuid.uuid4())],
ValueType.TIME_UUID: [str(uuid.uuid1())],
ValueType.UUID: [uuid.uuid4()],
ValueType.TIME_UUID: [uuid.uuid1()],
# List types
ValueType.BYTES_LIST: [[b"hello world"]],
ValueType.STRING_LIST: [["hello world"]],
Expand All @@ -1175,6 +1175,8 @@ def _get_sample_values_by_type(self) -> dict[ValueType, list[Any]]:
ValueType.FLOAT_LIST: [[1.0]],
ValueType.BOOL_LIST: [[True]],
ValueType.UNIX_TIMESTAMP_LIST: [[_utc_now()]],
ValueType.UUID_LIST: [[uuid.uuid4(), uuid.uuid4()]],
ValueType.TIME_UUID_LIST: [[uuid.uuid1(), uuid.uuid1()]],
}

@staticmethod
Expand Down
8 changes: 7 additions & 1 deletion sdk/python/feast/type_map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,13 @@ def feast_value_type_to_python_type(
if val_attr in ("uuid_list_val", "time_uuid_list_val"):
return [uuid_module.UUID(v) if isinstance(v, str) else v for v in val]

# Backward compatibility: handle UUIDs stored as string_val with feature_type hint
# Backward compatibility: handle UUIDs stored as string_val/string_list_val with feature_type hint
if feature_type in (ValueType.UUID, ValueType.TIME_UUID) and isinstance(val, str):
return uuid_module.UUID(val)
if feature_type in (ValueType.UUID_LIST, ValueType.TIME_UUID_LIST) and isinstance(
val, list
):
return [uuid_module.UUID(v) if isinstance(v, str) else v for v in val]

return val

Expand Down Expand Up @@ -1399,6 +1403,8 @@ def _convert_value_name_to_snowflake_udf(value_name: str, project_name: str) ->
"UNIX_TIMESTAMP_LIST": f"feast_{project_name}_snowflake_array_timestamp_to_list_unix_timestamp_proto",
"UUID": f"feast_{project_name}_snowflake_varchar_to_string_proto",
"TIME_UUID": f"feast_{project_name}_snowflake_varchar_to_string_proto",
"UUID_LIST": f"feast_{project_name}_snowflake_array_varchar_to_list_string_proto",
"TIME_UUID_LIST": f"feast_{project_name}_snowflake_array_varchar_to_list_string_proto",
}
return name_map[value_name].upper()

Expand Down