Visitar URL original
feat: Improve local dev experience with file-aware hooks and auto parallelization by franciscojavierarceo · Pull Request #5956 · feast-dev/feast · GitHub
Skip to content

feat: Improve local dev experience with file-aware hooks and auto parallelization #5956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 8 commits into from
Feb 13, 2026
Merged

feat: Improve local dev experience with file-aware hooks and auto parallelization #5956

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
82ae109
feat: Improve local dev experience with file-aware hooks and auto par…
franciscojavierarceo Feb 10, 2026
d2c57c1
fix: Address review feedback on pre-commit hooks
franciscojavierarceo Feb 10, 2026
6cf622e
fix: Restore --dist loadgroup to preserve xdist_group markers
franciscojavierarceo Feb 10, 2026
c29bf56
Merge branch 'master' into feat/improve-local-dev-experience
franciscojavierarceo Feb 12, 2026
a7b03b5
Update Makefile
franciscojavierarceo Feb 12, 2026
cd398ca
Update Makefile
franciscojavierarceo Feb 12, 2026
7f10bcc
fix: Use --dist loadgroup in test-python-integration-parallel
franciscojavierarceo Feb 12, 2026
13dc090
chore: Remove unused format-python-files and lint-python-files targets
franciscojavierarceo Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: Remove unused format-python-files and lint-python-files targets 
These Makefile targets were added but never wired up to pre-commit.
Pre-commit passes filenames as positional arguments, but Make expects
FILES="..." variable syntax. The inline bash commands in pre-commit
work correctly, so these targets are dead code.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
  • Loading branch information
@franciscojavierarceo @claude
franciscojavierarceo and claude committed Feb 12, 2026
commit 13dc09014d3b91de9e15bbecb0ac0f158209132c
20 changes: 0 additions & 20 deletions Makefile
View file
Open in desktop
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -58,31 +58,11 @@ format-python: ## Format Python code
uv run ruff check --fix sdk/python/feast/ sdk/python/tests/
uv run ruff format sdk/python/feast/ sdk/python/tests/

# File-aware format (for use with pre-commit, accepts file args)
format-python-files: ## Format specified Python files
@if [ -n "$(FILES)" ]; then \
uv run ruff check --fix $(FILES) && \
uv run ruff format $(FILES); \
else \
echo "Usage: make format-python-files FILES='file1.py file2.py'"; \
fi


lint-python: ## Lint Python code
uv run ruff check sdk/python/feast/ sdk/python/tests/
uv run ruff format --check sdk/python/feast/ sdk/python/tests/
uv run bash -c "cd sdk/python && mypy feast"

# File-aware lint (for use with pre-commit, accepts file args)
lint-python-files: ## Lint specified Python files
@if [ -n "$(FILES)" ]; then \
uv run ruff check $(FILES) && \
uv run ruff format --check $(FILES); \
else \
echo "Usage: make lint-python-files FILES='file1.py file2.py'"; \
fi


# New combined target
precommit-check: format-python lint-python ## Run all precommit checks
@echo "✅ All precommit checks passed"
Expand Down
Loading