Visitar URL original
perf: Replace MessageToDict with optimized custom dict builder by abhijeet-dhumal · Pull Request #6015 · feast-dev/feast · GitHub
Skip to content

perf: Replace MessageToDict with optimized custom dict builder #6015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 12 commits into from
May 28, 2026
Merged

perf: Replace MessageToDict with optimized custom dict builder #6015

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b28ddf9
perf: Replace MessageToDict with optimized custom dict builder
abhijeet-dhumal Feb 25, 2026
40846ad
Fix test: Use GetOnlineFeaturesResponseMetadata instead of non-existe…
abhijeet-dhumal Mar 2, 2026
ad4882b
fix: Rename to convert_response_to_dict, fix timestamp float-rounding…
abhijeet-dhumal Mar 10, 2026
698d0a1
fix: Return raw bytes to match proto_json.patch() behavior
abhijeet-dhumal Mar 10, 2026
0c0637b
fix: serialize top-level status field in convert_response_to_dict
abhijeet-dhumal May 27, 2026
3ac1755
fix: replace deprecated ORJSONResponse with JSONResponse
abhijeet-dhumal May 27, 2026
5fff274
fix: handle set, list, and map Value types in _value_to_native
abhijeet-dhumal May 27, 2026
b2f2909
fix: warn on scalar_map_val; fix test_unix_timestamp_list_val; docume…
abhijeet-dhumal May 27, 2026
c559ac5
docs: document float_precision=18 trade-off; add double_val round-tri…
abhijeet-dhumal May 27, 2026
388f89b
fix: remove leftover orjson dead code causing mypy no-redef error
abhijeet-dhumal May 27, 2026
ecce3cf
fix: base64-encode bytes_val and bytes_list_val for JSON serialization
abhijeet-dhumal May 27, 2026
25e99b1
style: remove extra blank line in feature_server_utils.py
abhijeet-dhumal May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Return raw bytes to match proto_json.patch() behavior 
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
  • Loading branch information
@abhijeet-dhumal
abhijeet-dhumal committed May 27, 2026
commit 698d0a17cb2c6c79cc1364f1985f5fb5552abeb4
9 changes: 5 additions & 4 deletions sdk/python/feast/feature_server_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
Values are serialized as native Python types (not wrapped dicts).
"""

import base64
from datetime import datetime, timezone
from typing import Any, Dict, Optional

Expand Down Expand Up @@ -52,12 +51,14 @@ def convert_response_to_dict(response: GetOnlineFeaturesResponse) -> Dict[str, A


def _value_to_native(v: Value) -> Optional[Any]:
"""Convert a Value proto to native Python type (matches proto_json.patch() format)."""
"""Convert a Value proto to native Python type (matches proto_json.patch() format).

Note: proto_json.patch() modifies MessageToDict to return raw bytes instead of
base64 encoding, so we return raw bytes here to match that behavior.
"""
which = v.WhichOneof("val")
if which is None or which == "null_val":
return None
elif which == "bytes_val":
return base64.b64encode(v.bytes_val).decode("ascii")
elif "_list_" in which:
return list(getattr(v, which).val)
else:
Expand Down
5 changes: 2 additions & 3 deletions sdk/python/tests/unit/test_feature_server_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
Related issue: https://github.com/feast-dev/feast/issues/6013
"""

import base64
import time

import pytest
Expand Down Expand Up @@ -99,7 +98,7 @@ def test_bytes_val(self):
data = b"\x00\x01\x02\x03"
v = Value(bytes_val=data)
result = _value_to_native(v)
assert result == base64.b64encode(data).decode("ascii")
assert result == data

def test_double_list_val(self):
v = Value(double_list_val=DoubleList(val=[1.1, 2.2, 3.3]))
Expand Down Expand Up @@ -357,7 +356,7 @@ def test_metadata_matches_patched_format(self):
)

def test_bytes_values_match_patched_message_to_dict(self):
"""Ensure bytes serialization matches proto_json.patch() format (base64)."""
"""Ensure bytes serialization matches proto_json.patch() format (raw bytes)."""
response = GetOnlineFeaturesResponse()
fv = response.results.add()
fv.values.append(Value(bytes_val=b"\x00\x01\x02\xff"))
Expand Down