Visitar URL original
feat: Support arm docker build by Anarion-zuo · Pull Request #6061 · feast-dev/feast · GitHub
Skip to content

feat: Support arm docker build #6061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 6 commits into from
Mar 7, 2026
Merged

feat: Support arm docker build #6061

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c9dc059
feat: support arm docker build
Anarion-zuo Mar 4, 2026
e3cd924
docker ci test
Anarion-zuo Mar 4, 2026
ea8f978
support dev
Anarion-zuo Mar 5, 2026
3455c02
publish feature-server-dev
Anarion-zuo Mar 5, 2026
82a7265
master_only trigger
Anarion-zuo Mar 6, 2026
5cba559
master_only docker build use make
Anarion-zuo Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: support arm docker build 
Signed-off-by: aaronzuo <anarionzuo@outlook.com>
  • Loading branch information
@Anarion-zuo @ntkathole
Anarion-zuo authored and ntkathole committed Mar 6, 2026
commit c9dc05986013d08de8acdc772f826aac77367be4
20 changes: 16 additions & 4 deletions .github/workflows/publish_images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,29 @@ jobs:
env:
VERSION_WITHOUT_PREFIX: ${{ steps.get-version.outputs.version_without_prefix }}
run: |
make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${VERSION_WITHOUT_PREFIX}
if [ "${{ matrix.component }}" = "feature-server" ]; then
make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${VERSION_WITHOUT_PREFIX} DOCKER_PUSH=true DOCKER_PLATFORMS=linux/amd64,linux/arm64
else
make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${VERSION_WITHOUT_PREFIX}
fi
- name: Push versioned images
env:
VERSION_WITHOUT_PREFIX: ${{ steps.get-version.outputs.version_without_prefix }}
HIGHEST_SEMVER_TAG: ${{ steps.get-version.outputs.highest_semver_tag }}
run: |
make push-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${VERSION_WITHOUT_PREFIX}
if [ "${{ matrix.component }}" = "feature-server" ]; then
echo "feature-server image pushed via buildx during build step"
else
make push-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${VERSION_WITHOUT_PREFIX}
fi

echo "Only push to latest tag if tag is the highest semver version $HIGHEST_SEMVER_TAG"
if [ "${VERSION_WITHOUT_PREFIX}" = "${HIGHEST_SEMVER_TAG:1}" ]
then
docker tag ${REGISTRY}/${{ matrix.component }}:${VERSION_WITHOUT_PREFIX} ${REGISTRY}/${{ matrix.component }}:latest
docker push ${REGISTRY}/${{ matrix.component }}:latest
if [ "${{ matrix.component }}" = "feature-server" ]; then
docker buildx imagetools create -t ${REGISTRY}/feature-server:latest ${REGISTRY}/feature-server:${VERSION_WITHOUT_PREFIX}
else
docker tag ${REGISTRY}/${{ matrix.component }}:${VERSION_WITHOUT_PREFIX} ${REGISTRY}/${{ matrix.component }}:latest
docker push ${REGISTRY}/${{ matrix.component }}:latest
fi
fi
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,10 +659,10 @@ push-feature-server-docker: ## Push Feature Server Docker image
docker push $(REGISTRY)/feature-server:$(VERSION)

build-feature-server-docker: ## Build Feature Server Docker image
docker buildx build \
docker buildx build $(if $(DOCKER_PLATFORMS),--platform $(DOCKER_PLATFORMS),) \
-t $(REGISTRY)/feature-server:$(VERSION) \
-f sdk/python/feast/infra/feature_servers/multicloud/Dockerfile \
--load sdk/python/feast/infra/feature_servers/multicloud
$(if $(filter true,$(DOCKER_PUSH)),--push,--load) sdk/python/feast/infra/feature_servers/multicloud

push-feature-transformation-server-docker: ## Push Feature Transformation Server Docker image
docker push $(REGISTRY)/feature-transformation-server:$(VERSION)
Expand Down