Visitar URL original
feat: Adding optional name to Aggregation (feast-dev#5994) by nquinn408 · Pull Request #6083 · feast-dev/feast · GitHub
Skip to content

feat: Adding optional name to Aggregation (feast-dev#5994) #6083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 7 commits into from
Mar 10, 2026
Merged

feat: Adding optional name to Aggregation (feast-dev#5994) #6083

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
02df4b2
feat: Adding optional name to Aggregation (feast-dev#5994)
nickquinn408 Mar 9, 2026
a684be2
Fix lint-python test
nickquinn408 Mar 9, 2026
8c312c8
Merge branch 'master' into optional_aggregation_name
nquinn408 Mar 9, 2026
0bfaeaa
Adding name to documentation
nickquinn408 Mar 9, 2026
cf0a274
Devin feedback
nickquinn408 Mar 9, 2026
001952d
Update sdk/python/feast/aggregation/__init__.py
nquinn408 Mar 9, 2026
30468f2
Merge branch 'master' into optional_aggregation_name
nquinn408 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint-python test 
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
  • Loading branch information
@nickquinn408
nickquinn408 committed Mar 9, 2026
commit a684be2affd7b3621380276f3a548342d5efffcb
6 changes: 5 additions & 1 deletion sdk/python/tests/unit/test_aggregation_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,11 @@ def test_aggregation_specs_to_agg_ops_time_window_unsupported(error_message: str

def test_aggregation_specs_to_agg_ops_custom_name():
agg_specs = [
DummyAggregation(function="sum", column="seconds_watched", name="sum_seconds_watched_per_ad_1d"),
DummyAggregation(
function="sum",
column="seconds_watched",
name="sum_seconds_watched_per_ad_1d",
),
]

agg_ops = aggregation_specs_to_agg_ops(
Expand Down
Loading