Visitar URL original
feat: Add online store read and ODFV transformation duration metrics with per-ODFV opt-in by ntkathole · Pull Request #6125 · feast-dev/feast · GitHub
Skip to content

feat: Add online store read and ODFV transformation duration metrics with per-ODFV opt-in - #6125

Merged
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
ntkathole:odfv_metrics
Mar 24, 2026
Merged

feat: Add online store read and ODFV transformation duration metrics with per-ODFV opt-in#6125
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
ntkathole:odfv_metrics

Conversation

@ntkathole

@ntkathole ntkathole commented Mar 18, 2026 •
edited by devin-ai-integration Bot
Loading

Copy link
Copy Markdown
Member

What this PR does / why we need it:

This PR adds three new Prometheus histogram metrics to the Feast feature server - online store reads, read-path ODFV transformations, and write-path ODFV transformations.

  • feast_feature_server_online_store_read_duration_seconds - captures the total time spent reading from the online store (covers both sync for-loop and async asyncio.gather paths across all backends)
  • feast_feature_server_transformation_duration_seconds (odfv_name, mode) - captures per-ODFV read-path transformation time during /get-online-features (Pandas, Python, Substrait modes)
  • feast_feature_server_write_transformation_duration_seconds (odfv_name, mode) - captures per-ODFV write-path transformation time during push/materialize with write_to_online_store=True
Screenshot 2026-03-18 at 1 46 01 PM
Open with Devin

@ntkathole ntkathole self-assigned this Mar 18, 2026
@ntkathole
ntkathole requested review from a team as code owners March 18, 2026 08:17
@ntkathole
ntkathole requested review from haoxu0, lokeshrangineni and robhowley and removed request for a team March 18, 2026 08:17
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

jyejare
jyejare approved these changes Mar 18, 2026
View reviewed changes

@jyejare jyejare left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few minor comments.

Comment thread docs/reference/feature-servers/python-feature-server.md Outdated
Comment thread sdk/python/feast/infra/online_stores/online_store.py
Comment thread sdk/python/feast/utils.py
Comment thread sdk/python/feast/utils.py
@ntkathole
feat: Added odfv transformations metrics
e7eec52 
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
@franciscojavierarceo
franciscojavierarceo merged commit 8b5a526 into feast-dev:master Mar 24, 2026
33 of 34 checks passed
@ntkathole ntkathole mentioned this pull request Mar 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jyejare jyejare jyejare approved these changes
@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes
@robhowley robhowley Awaiting requested review from robhowley robhowley is a code owner automatically assigned from feast-dev/maintainers
@lokeshrangineni lokeshrangineni Awaiting requested review from lokeshrangineni lokeshrangineni is a code owner automatically assigned from feast-dev/maintainers
@haoxu0 haoxu0 Awaiting requested review from haoxu0 haoxu0 is a code owner automatically assigned from feast-dev/maintainers

Assignees

@ntkathole ntkathole

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ntkathole @franciscojavierarceo @jyejare