Visitar URL original
feat: Add version indicators to lineage graph nodes by franciscojavierarceo · Pull Request #6187 · feast-dev/feast · GitHub
Skip to content

feat: Add version indicators to lineage graph nodes #6187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 4 commits into from
Mar 27, 2026
Merged

feat: Add version indicators to lineage graph nodes #6187

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb38b9e
feat: Add version indicators to lineage graph nodes
franciscojavierarceo Mar 27, 2026
0984322
fix: Only show version badge when currentVersionNumber > 1
franciscojavierarceo Mar 27, 2026
390f069
Merge branch 'master' into update-lineage
franciscojavierarceo Mar 27, 2026
76235c8
fix: Code formatting for version indicators
franciscojavierarceo Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Code formatting for version indicators 
Apply prettier formatting to fix CI formatting checks.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
@franciscojavierarceo @claude
franciscojavierarceo and claude committed Mar 27, 2026
commit 76235c895b7fb712ee38856281396f618e817b04
29 changes: 14 additions & 15 deletions ui/src/components/RegistryVisualization.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,21 +304,20 @@ describe("RegistryVisualization version indicators", () => {
spec: { name: "my_entity" },
}),
],
featureViewVersionHistory:
feast.core.FeatureViewVersionHistory.create({
records: [
feast.core.FeatureViewVersionRecord.create({
featureViewName: "versioned_fv",
versionNumber: 1,
description: "Initial version",
}),
feast.core.FeatureViewVersionRecord.create({
featureViewName: "versioned_fv",
versionNumber: 2,
description: "Added new features",
}),
],
}),
featureViewVersionHistory: feast.core.FeatureViewVersionHistory.create({
records: [
feast.core.FeatureViewVersionRecord.create({
featureViewName: "versioned_fv",
versionNumber: 1,
description: "Initial version",
}),
feast.core.FeatureViewVersionRecord.create({
featureViewName: "versioned_fv",
versionNumber: 2,
description: "Added new features",
}),
],
}),
});

const relationships = [
Expand Down
9 changes: 5 additions & 4 deletions ui/src/components/RegistryVisualization.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,7 @@ const CustomNode = ({ data }: { data: NodeData }) => {
const icon = getNodeIcon(data.type);
const [isHovered, setIsHovered] = useState(false);
const hasPermissions = data.permissions && data.permissions.length > 0;
const hasVersion =
data.versionNumber != null && data.versionNumber > 1;
const hasVersion = data.versionNumber != null && data.versionNumber > 1;

const handleClick = () => {
let path;
Expand Down Expand Up @@ -559,8 +558,10 @@ const registryToFlow = (
const name = groupedNames[i];
const records = grouped[name];
records.sort(
(a: feast.core.IFeatureViewVersionRecord, b: feast.core.IFeatureViewVersionRecord) =>
(b.versionNumber ?? 0) - (a.versionNumber ?? 0),
(
a: feast.core.IFeatureViewVersionRecord,
b: feast.core.IFeatureViewVersionRecord,
) => (b.versionNumber ?? 0) - (a.versionNumber ?? 0),
);
versionInfoMap.set(name, {
totalVersions: records.length,
Expand Down
Loading