Visitar URL original
feat: Add SingleStore online store support for feature view versioning by antznette1 · Pull Request #6195 · feast-dev/feast · GitHub
Skip to content
Open
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
1308981
Add SingleStore online store support for feature view versioning
antznette1 Mar 29, 2026
dfb0a38
Add versioned table ids + teardown for SingleStore online store
antznette1 Apr 1, 2026
a557a52
Harden SingleStore teardown and quote identifiers
antznette1 Apr 1, 2026
8a78be4
Fix SingleStore teardown LIKE escaping
antznette1 Apr 2, 2026
bef7975
Add SingleStore online store support for feature view versioning
antznette1 Mar 29, 2026
3f3aedd
Pass registry to online store teardown
antznette1 Apr 3, 2026
630d6d0
Fix BaseRegistry typing imports
antznette1 Apr 3, 2026
e3bd360
Fix online store update/teardown and pre-commit issues
antznette1 Apr 3, 2026
bc0e487
Fix HybridOnlineStore teardown routing
antznette1 Apr 3, 2026
a5e343f
Fix SingleStore teardown fallback table dropping
antznette1 Apr 3, 2026
e5e3ee7
Update sdk/python/feast/infra/online_stores/singlestore_online_store/…
antznette1 Apr 3, 2026
dc3a739
Update sdk/python/feast/infra/online_stores/singlestore_online_store/…
antznette1 Apr 3, 2026
1c7ca08
Stabilize CI: pgvector readiness + operator base images
antznette1 Apr 4, 2026
48bfb8c
Make metrics import resilient when prometheus_client is unavailable
antznette1 Apr 4, 2026
e03179e
Revert operator Dockerfile changes
antznette1 Apr 6, 2026
546c9fd
Fix MySQL/Postgres versioned online read support
antznette1 Apr 8, 2026
d1fcc89
Fix MySQL batch write entity key serialization
antznette1 Apr 8, 2026
8a64179
Run format-files pre-commit fixes
antznette1 Apr 9, 2026
fa2be47
fix: restore versioned naming helper and enable versioned reads
antznette1 Apr 19, 2026
a1bef33
Fix operator Go toolset + refactor SingleStore teardown
antznette1 Apr 23, 2026
08d73df
Revert unrelated changes; restore SingleStore _table_id helper
antznette1 Apr 23, 2026
301f599
Fix HybridOnlineStore teardown registry forwarding
antznette1 Apr 24, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make metrics import resilient when prometheus_client is unavailable
Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
  • Loading branch information
antznette1 committed Apr 16, 2026
commit 48bfb8cfe79a4d94f15e9c370b7b66d97df4fefa
34 changes: 33 additions & 1 deletion sdk/python/feast/metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,33 @@ def _cleanup_multiprocess_dir():
atexit.register(_cleanup_multiprocess_dir)

# Now safe to import prometheus_client — it will detect the env var.
from prometheus_client import Counter, Gauge, Histogram # noqa: E402
_prometheus_available = True
Comment thread
antznette1 marked this conversation as resolved.
Outdated
try:
from prometheus_client import Counter, Gauge, Histogram # noqa: E402
except Exception:
_prometheus_available = False

class _NoOpMetric:
def labels(self, **kwargs):
return self

def inc(self, amount: float = 1):
return None

def observe(self, amount: float):
return None

def set(self, value: float):
return None

def Counter(*args, **kwargs): # type: ignore
return _NoOpMetric()

def Gauge(*args, **kwargs): # type: ignore
return _NoOpMetric()

def Histogram(*args, **kwargs): # type: ignore
return _NoOpMetric()


# ---------------------------------------------------------------------------
Expand Down Expand Up @@ -496,6 +522,12 @@ def start_metrics_server(
"""
global _config

if not _prometheus_available:
logger.warning(
"Prometheus metrics are unavailable because prometheus_client could not be imported."
)
return

if metrics_config is not None:
_config = metrics_config
else:
Expand Down