Visitar URL original
fix: Correct project_id scoping in get_user_metadata and delete_project by Abhishek8108 · Pull Request #6248 · feast-dev/feast · GitHub
Skip to content

fix: Correct project_id scoping in get_user_metadata and delete_project #6248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 1 commit into from
Apr 10, 2026
Merged

fix: Correct project_id scoping in get_user_metadata and delete_project #6248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: correct project_id scoping in get_user_metadata and delete_project 
get_user_metadata was filtering only by feature view name, allowing a
shared Snowflake registry to return user metadata from a different
project's feature view with the same name. Added project_id = '{project}'
to the WHERE clause, consistent with apply_user_metadata.

delete_project was interpolating a Project object into the SQL string
instead of the project name string, which would use __str__ of the object
rather than the actual name. Changed to use the `name` parameter directly.

Signed-off-by: Abhishek8108 <87538407+Abhishek8108@users.noreply.github.com>
  • Loading branch information
@Abhishek8108 @ntkathole
Abhishek8108 authored and ntkathole committed Apr 10, 2026
commit e0acd111635be29d6297adcc807fc29286dc0cd7
5 changes: 3 additions & 2 deletions sdk/python/feast/infra/registry/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,7 +1116,8 @@ def get_user_metadata(
FROM
{self.registry_path}."{fv_table_str}"
WHERE
{fv_column_name}_name = '{feature_view.name}'
project_id = '{project}'
AND {fv_column_name}_name = '{feature_view.name}'
LIMIT 1
"""
df = execute_snowflake_statement(conn, query).fetch_pandas_all()
Expand Down Expand Up @@ -1322,7 +1323,7 @@ def delete_project(
query = f"""
DELETE FROM {self.registry_path}."{table}"
WHERE
project_id = '{project}'
project_id = '{name}'
"""
execute_snowflake_statement(conn, query)
return
Expand Down
Loading