Visitar URL original
fix(helm): Avoid nil pointer for metrics.enabled inside podAnnotations by antznette1 · Pull Request #6251 · feast-dev/feast · GitHub
Skip to content

fix(helm): Avoid nil pointer for metrics.enabled inside podAnnotations #6251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 2 commits into from
Apr 10, 2026
Merged

fix(helm): Avoid nil pointer for metrics.enabled inside podAnnotations #6251

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fa06b1
Fix helm podAnnotations metrics context
antznette1 Apr 9, 2026
d48239c
Fix helm metrics annotation with empty podAnnotations
antznette1 Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix helm metrics annotation with empty podAnnotations 
Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
  • Loading branch information
@antznette1 @ntkathole
antznette1 authored and ntkathole committed Apr 10, 2026
commit d48239ce102296ba408779cfabe082bfeb65f3bf
4 changes: 3 additions & 1 deletion infra/charts/feast-feature-server/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@ spec:
{{- include "feast-feature-server.selectorLabels" . | nindent 6 }}
template:
metadata:
{{- with .Values.podAnnotations }}
{{- if or .Values.podAnnotations .Values.metrics.enabled }}
annotations:
{{- with .Values.podAnnotations }}
{{- toYaml . | nindent 8 }}
{{- end }}
{{- if $.Values.metrics.enabled }}
instrumentation.opentelemetry.io/inject-python: "true"
{{- end }}
Comment thread
antznette1 marked this conversation as resolved.
Expand Down
Loading