Visitar URL original
fix: Fix five bugs in milvus online store by korbonits · Pull Request #6275 · feast-dev/feast · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: fix sphinx warnings from new package documentation
No new warning categories are introduced by adding feast.aggregation,
feast.dbt, and feast.openlineage to the Sphinx docs. The 10 new
"more than one target found" warnings follow the same pre-existing
pattern (8 already present) caused by feast.__init__ re-exporting
classes under multiple paths.

Fixes applied:
- Remove :undoc-members: from dataclass automodules (Aggregation,
  IRMetadata, OpenLineageConfig) to prevent duplicate attribute docs
- Document re-exporting __init__ packages at package level only to
  avoid duplicate descriptions from submodule entries
- Fix markdown-style code fences in openlineage/__init__.py docstring
- Fix RST formatting in client.py Example section (Example::) and
  emitter.py ASCII art diagram (literal block)
- Fix repo_config.py field docstring that triggered an ambiguous
  OpenLineageConfig cross-reference

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Alex Korbonits <alex@korbonits.com>
  • Loading branch information
korbonits and claude committed Apr 13, 2026
commit a1099d63c3dc606ec1c7b0c4bed02a01c234ff34
1 change: 0 additions & 1 deletion sdk/python/docs/source/feast.aggregation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,4 @@ Module contents

.. automodule:: feast.aggregation
:members:
:undoc-members:
:show-inheritance:
28 changes: 0 additions & 28 deletions sdk/python/docs/source/feast.aggregation.tiling.rst
Original file line number Diff line number Diff line change
@@ -1,37 +1,9 @@
feast.aggregation.tiling package
=================================

Submodules
----------

feast.aggregation.tiling.base module
-------------------------------------

.. automodule:: feast.aggregation.tiling.base
:members:
:undoc-members:
:show-inheritance:

feast.aggregation.tiling.orchestrator module
--------------------------------------------

.. automodule:: feast.aggregation.tiling.orchestrator
:members:
:undoc-members:
:show-inheritance:

feast.aggregation.tiling.tile\_subtraction module
-------------------------------------------------

.. automodule:: feast.aggregation.tiling.tile_subtraction
:members:
:undoc-members:
:show-inheritance:

Module contents
---------------

.. automodule:: feast.aggregation.tiling
:members:
:undoc-members:
:show-inheritance:
44 changes: 0 additions & 44 deletions sdk/python/docs/source/feast.openlineage.rst
Original file line number Diff line number Diff line change
@@ -1,53 +1,9 @@
feast.openlineage package
=========================

Submodules
----------

feast.openlineage.client module
--------------------------------

.. automodule:: feast.openlineage.client
:members:
:undoc-members:
:show-inheritance:

feast.openlineage.config module
--------------------------------

.. automodule:: feast.openlineage.config
:members:
:undoc-members:
:show-inheritance:

feast.openlineage.emitter module
---------------------------------

.. automodule:: feast.openlineage.emitter
:members:
:undoc-members:
:show-inheritance:

feast.openlineage.facets module
--------------------------------

.. automodule:: feast.openlineage.facets
:members:
:undoc-members:
:show-inheritance:

feast.openlineage.mappers module
---------------------------------

.. automodule:: feast.openlineage.mappers
:members:
:undoc-members:
:show-inheritance:

Module contents
---------------

.. automodule:: feast.openlineage
:members:
:undoc-members:
:show-inheritance:
8 changes: 0 additions & 8 deletions sdk/python/docs/source/feast.rst
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,6 @@ Subpackages
Submodules
----------

feast.aggregation module
------------------------

.. automodule:: feast.aggregation
:members:
:undoc-members:
:show-inheritance:

feast.arrow\_error\_handler module
----------------------------------

Expand Down
34 changes: 17 additions & 17 deletions sdk/python/feast/openlineage/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,27 +35,27 @@
Usage:
Simply configure OpenLineage in your feature_store.yaml:

```yaml
project: my_project
# ... other config ...

openlineage:
enabled: true
transport_type: http
transport_url: http://localhost:5000
transport_endpoint: api/v1/lineage
namespace: my_namespace # Optional: defaults to project name
```
.. code-block:: yaml

project: my_project
# ... other config ...

openlineage:
enabled: true
transport_type: http
transport_url: http://localhost:5000
transport_endpoint: api/v1/lineage
namespace: my_namespace # Optional: defaults to project name

Then use Feast normally - lineage events are emitted automatically!

```python
from feast import FeatureStore
.. code-block:: python

from feast import FeatureStore

fs = FeatureStore(repo_path="feature_repo")
fs.apply([entity, feature_view, feature_service]) # Emits lineage
fs.materialize(start, end) # Emits START/COMPLETE/FAIL events
```
fs = FeatureStore(repo_path="feature_repo")
fs.apply([entity, feature_view, feature_service]) # Emits lineage
fs.materialize(start, end) # Emits START/COMPLETE/FAIL events
"""

from feast.openlineage.client import FeastOpenLineageClient
Expand Down
3 changes: 2 additions & 1 deletion sdk/python/feast/openlineage/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ class FeastOpenLineageClient:
from Feast operations like materialization, feature retrieval, and
registry changes.

Example:
Example::

from feast.openlineage import FeastOpenLineageClient, OpenLineageConfig

config = OpenLineageConfig(
Expand Down
4 changes: 3 additions & 1 deletion sdk/python/feast/openlineage/emitter.py
Original file line number Diff line number Diff line change
Expand Up @@ -644,11 +644,13 @@ def emit_apply(
1. feast_feature_views_{project}: DataSources + Entities → FeatureViews
2. feast_feature_services_{project}: FeatureViews → FeatureServices

This creates a lineage graph matching Feast UI:
This creates a lineage graph matching Feast UI::

DataSource ──→ FeatureView ──→ FeatureService
↑
Entity


Args:
objects: List of Feast objects being applied
project: Project name
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/repo_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ class RepoConfig(FeastBaseModel):
""" MaterializationConfig: Configuration options for feature materialization behavior. """

openlineage_config: Optional[OpenLineageConfig] = Field(None, alias="openlineage")
""" OpenLineageConfig: Configuration for OpenLineage data lineage integration (optional). """
""" Configuration for OpenLineage data lineage integration (optional). """

def __init__(self, **data: Any):
super().__init__(**data)
Expand Down
Loading