Visitar URL original
fix: Add project filter to apply_data_source and delete_data_source (closes #6206) by mailtoboggavarapu-coder · Pull Request #6322 · feast-dev/feast · GitHub
Skip to content

fix: Add project filter to apply_data_source and delete_data_source (closes #6206) #6322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 4 commits into from
May 1, 2026
Merged

fix: Add project filter to apply_data_source and delete_data_source (closes #6206) #6322

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd8874a
fix: Add project filter to apply_data_source and delete_data_source (…
mailtoboggavarapu-coder Apr 23, 2026
b7fa291
test: add cross-project isolation tests for apply/delete_data_source
mailtoboggavarapu-coder Apr 23, 2026
c62c5f1
style: remove extra blank line between decorator and function
mailtoboggavarapu-coder Apr 26, 2026
9817a6e
fix(tests): scope cross-project isolation tests to local_registry only
mailtoboggavarapu-coder Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(tests): scope cross-project isolation tests to local_registry only 
Changed parametrize decorators from all_fixtures to [lazy_fixture("local_registry")] for
both new test functions to avoid polluting the session-scoped sqlite_registry fixture.

Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
  • Loading branch information
@mailtoboggavarapu-coder @ntkathole
mailtoboggavarapu-coder authored and ntkathole committed May 1, 2026
commit 9817a6ed5c7e71702e6c1e6843d6cfe05072d88e
6 changes: 3 additions & 3 deletions sdk/python/tests/integration/registration/test_universal_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,7 @@ def test_apply_data_source_with_timestamps(test_registry):
@pytest.mark.integration
@pytest.mark.parametrize(
"test_registry",
all_fixtures,
[lazy_fixture("local_registry")],
)
def test_apply_data_source_cross_project_isolation(test_registry):
"""Test that apply_data_source uses project-scoped filtering.
Expand Down Expand Up @@ -938,7 +938,7 @@ def test_apply_data_source_cross_project_isolation(test_registry):
assert len(sources_a) == 1
assert len(sources_b) == 1

# Paths must be project-specific — not overwritten cross-project
# Paths must be project-specific — not overwritten cross-project
assert sources_a[0].path == "file://feast/project_a.parquet"
assert sources_b[0].path == "file://feast/project_b.parquet"

Expand All @@ -963,7 +963,7 @@ def test_apply_data_source_cross_project_isolation(test_registry):
@pytest.mark.integration
@pytest.mark.parametrize(
"test_registry",
all_fixtures,
[lazy_fixture("local_registry")],
)
def test_delete_data_source_project_scoped(test_registry):
"""Test that delete_data_source only removes the source from the given project.
Expand Down
Loading