Visitar URL original
feat: Allow CRUD on entities, data sources, and feature views from UI by rohit-bharmal · Pull Request #6412 · feast-dev/feast · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: Remove unused proxy setting and streamline data loading in …
…data sources and other

Signed-off-by: Rohit Bharmal <rohitbharmal123@gmail.com>
  • Loading branch information
rohit-bharmal committed Jun 8, 2026
commit 209de13be5aa047f3fffa47bd9913fb95bb922bc
1 change: 0 additions & 1 deletion ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"optional": true
}
},
"proxy": "http://localhost:6572",
"dependencies": {
"@elastic/datemath": "^5.0.3",
"@elastic/eui": "^95.12.0",
Expand Down
18 changes: 0 additions & 18 deletions ui/src/pages/data-sources/DataSourceOverviewTab.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -286,24 +286,6 @@ const DataSourceOverviewTab = () => {
<EuiText>No consuming views</EuiText>
)}
</EuiPanel>
<EuiSpacer size="m" />
<EuiPanel hasBorder={true}>
<EuiTitle size="xs">
<h2>Permissions</h2>
</EuiTitle>
<EuiHorizontalRule margin="xs"></EuiHorizontalRule>
{registryQuery.data?.permissions ? (
<PermissionsDisplay
permissions={getEntityPermissions(
registryQuery.data.permissions,
FEAST_FCO_TYPES.dataSource,
dsName,
)}
/>
) : (
<EuiText>No consuming feature views</EuiText>
)}
</EuiPanel>
</EuiFlexItem>
</EuiFlexGroup>
</React.Fragment>
Expand Down
10 changes: 2 additions & 8 deletions ui/src/pages/data-sources/Index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const useLoadDatasources = () => {
});
};

const filterFn = (data: feast.core.IDataSource[], searchTokens: string[]) => {
const filterFn = (data: any[], searchTokens: string[]) => {
let filteredByTags = data;

if (searchTokens.length) {
Expand Down Expand Up @@ -107,13 +107,7 @@ const Index = () => {
const { projectName } = useParams();
const { isV2 } = useUIVersion();

const {
isLoading,
isSuccess,
isError,
data: queryData,
} = useLoadDataSourcesREST(projectName || "");
const data = queryData?.dataSources;
const { isLoading, isSuccess, isError, data } = useLoadDatasources();

const [isModalOpen, setIsModalOpen] = useState(false);
const [successMessage, setSuccessMessage] = useState<string | null>(null);
Expand Down
8 changes: 1 addition & 7 deletions ui/src/pages/entities/Index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,7 @@ const Index = () => {
const { projectName } = useParams();
const { isV2 } = useUIVersion();

const {
isLoading,
isSuccess,
isError,
data: queryData,
} = useLoadEntitiesREST(projectName || "");
const data = queryData?.entities;
const { isLoading, isSuccess, isError, data } = useLoadEntities();

const [isModalOpen, setIsModalOpen] = useState(false);
const [successMessage, setSuccessMessage] = useState<string | null>(null);
Expand Down
31 changes: 17 additions & 14 deletions ui/src/pages/feature-views/Index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ import { useUIVersion } from "../../contexts/UIVersionContext";
import useResourceQuery, {
featureViewListPath,
restFeatureViewsToMergedList,
entityListPath,
dataSourceListPath,
} from "../../queries/useResourceQuery";

const useLoadFeatureViews = () => {
Expand Down Expand Up @@ -125,19 +127,20 @@ const Index = () => {
const { projectName } = useParams();
const { isV2 } = useUIVersion();

const {
isLoading,
isSuccess,
isError,
data: queryData,
} = useLoadFeatureViewsREST(projectName || "");

const data = queryData?.featureViews
? queryData.featureViews.map(mapRestFvToGenericType)
: undefined;
const { isLoading, isSuccess, isError, data } = useLoadFeatureViews();

const entitiesQuery = useLoadEntitiesREST(projectName || "");
const dataSourcesQuery = useLoadDataSourcesREST(projectName || "");
const entitiesQuery = useResourceQuery<any[]>({
resourceType: "entities-list-fv-prereq",
project: projectName,
restPath: entityListPath(projectName),
restSelect: (d) => d.entities,
});
const dataSourcesQuery = useResourceQuery<any[]>({
resourceType: "data-sources-list-fv-prereq",
project: projectName,
restPath: dataSourceListPath(projectName),
restSelect: (d) => d.dataSources,
});

const tagAggregationQuery = useFeatureViewTagsAggregation();
const [isModalOpen, setIsModalOpen] = useState(false);
Expand All @@ -148,8 +151,8 @@ const Index = () => {

const handleCreateClick = () => {
const missingDeps: string[] = [];
const entities = entitiesQuery.data?.entities || [];
const dataSources = dataSourcesQuery.data?.dataSources || [];
const entities = entitiesQuery.data || [];
const dataSources = dataSourcesQuery.data || [];

if (entities.length === 0) missingDeps.push("entities");
if (dataSources.length === 0) missingDeps.push("data sources");
Expand Down