Visitar URL original
fix: Fix ValueError in signal handling for Trino worker threads by mbm-codes · Pull Request #6428 · feast-dev/feast · GitHub
Skip to content

fix: Fix ValueError in signal handling for Trino worker threads #6428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 4 commits into from
Jul 1, 2026
+52 −2
Merged

fix: Fix ValueError in signal handling for Trino worker threads #6428

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9776761
fix: fix signal.signal() ValueError in Trino worker threads
mbm-codes May 21, 2026
c5ca3f8
test: patch signal.signal in main thread test to avoid handler leak
mbm-codes Jun 1, 2026
d9d3fab
Update sdk/python/feast/infra/offline_stores/contrib/trino_offline_st…
mbm-codes Jun 3, 2026
4c1e5d8
test: address PR feedback for worker thread errors and signals
mbm-codes Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update sdk/python/feast/infra/offline_stores/contrib/trino_offline_st… 
…ore/tests/test_trino_queries.py

Apply reviewer suggestion: verify correct signals and handler in test

Co-authored-by: Jitendra Yejare <jyejare@redhat.com>
Signed-off-by: MBM <mihir105@gmail.com>
  • Loading branch information
@mbm-codes @jyejare @ntkathole
2 people authored and ntkathole committed Jul 1, 2026
commit d9d3faba4baa3c76970db781a8946f304187d5cf
7 changes: 4 additions & 3 deletions ...python/feast/infra/offline_stores/contrib/trino_offline_store/tests/test_trino_queries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ def test_query_init_in_main_thread_registers_signals():
# Should not raise any exception in main thread
cursor = MagicMock()
with patch("signal.signal") as mock_signal:
query = Query(query_text="SELECT 1", cursor=cursor)
assert query.query_text == "SELECT 1"
# Expected signal.signal to be called twice for SIGINT and SIGTERM
# Verify signal handlers are registered correctly
assert mock_signal.call_count == 2
mock_signal.assert_any_call(signal.SIGINT, query.cancel)
mock_signal.assert_any_call(signal.SIGTERM, query.cancel)
assert mock_signal.call_count == 2


Expand Down