Visitar URL original
feat: Retrieve historical features from BigQuery without entity_df by singhhimanshu0811 · Pull Request #6569 · feast-dev/feast · GitHub
Skip to content

feat: Retrieve historical features from BigQuery without entity_df #6569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 17 commits into from
Jun 30, 2026
Merged

feat: Retrieve historical features from BigQuery without entity_df #6569

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b49d000
retrieval from bigquery without entity df
Jun 29, 2026
fc02ba5
feat: Implement RegistryServer.Proto RPC with RBAC-filtered response …
nquinn408 Jun 28, 2026
e726b07
feat(operator): integrate cluster TLS profile for OCP 5.0 compliance
ugiordan Jun 10, 2026
e98aa8e
fixing linter error
Jun 29, 2026
d9f37a9
fixing unit test error
Jun 29, 2026
69f09cd
linter errors
Jun 29, 2026
2b0e913
pulling from main
Jun 29, 2026
0e4d2a7
Merge branch 'master' into feat/time-retrieval-bigquery
singhhimanshu0811 Jun 30, 2026
199c14a
applied recos
Jun 30, 2026
f4b4af8
Merge branch 'feat/time-retrieval-bigquery' of https://github.com/sin…
Jun 30, 2026
b458d3d
unit tests and linter error
Jun 30, 2026
ad9ce6d
pre commit checks
Jun 30, 2026
ed1c371
pre commit checks
Jun 30, 2026
67ce1d7
Merge branch 'master' into feat/time-retrieval-bigquery
singhhimanshu0811 Jun 30, 2026
9c11934
fixing errors
Jun 30, 2026
3ea6bcd
casting null as string
Jun 30, 2026
05ac83b
fixing test cases
Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linter errors 
Signed-off-by: Himanshu Singh <himanshu.singh@walmart.com>
  • Loading branch information
Himanshu Singh
Himanshu Singh committed Jun 29, 2026
commit 69f09cd0b47405a6e286e14c9e7c5cc2e76ec72b
1 change: 1 addition & 0 deletions sdk/python/feast/infra/offline_stores/bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,7 @@ def query_generator() -> Iterator[str]:
expected_join_keys = offline_utils.get_expected_join_keys(
project, feature_views, registry
)
assert entity_schema is not None
offline_utils.assert_expected_columns_in_entity_df(
entity_schema, expected_join_keys, event_timestamp_col
)
Expand Down
2 changes: 0 additions & 2 deletions sdk/python/feast/infra/offline_stores/offline_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,8 +431,6 @@ def format_date(val: Union[str, datetime]) -> str:
return " AND ".join(filters) if filters else ""




def gather_all_entities(fv_query_contexts: List[FeatureViewQueryContext]):
all_entities: List[str] = []
for ctx in fv_query_contexts:
Expand Down
89 changes: 62 additions & 27 deletions sdk/python/tests/unit/infra/offline_stores/test_bigquery_non_entity_mode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,12 @@
BigQueryOfflineStoreConfig,
BigQueryRetrievalJob,
_bq_create_entity_union_table,

)
from feast.infra.offline_stores.offline_utils import gather_all_entities
from feast.infra.offline_stores.bigquery_source import BigQuerySource
from feast.infra.offline_stores.offline_utils import FeatureViewQueryContext
from feast.infra.offline_stores.offline_utils import (
FeatureViewQueryContext,
gather_all_entities,
)
from feast.infra.online_stores.sqlite import SqliteOnlineStoreConfig
from feast.repo_config import RepoConfig

Expand Down Expand Up @@ -145,9 +146,7 @@ def _make_client(self) -> MagicMock:

@patch("feast.infra.offline_stores.bigquery.block_until_done")
@patch("feast.infra.offline_stores.bigquery._utc_now")
def test_single_view_creates_table_with_correct_sql(
self, mock_utc_now, mock_block
):
def test_single_view_creates_table_with_correct_sql(self, mock_utc_now, mock_block):
mock_utc_now.return_value = END
client = self._make_client()
fv = _make_feature_view_mock("fv1", ["customer_id"])
Expand Down Expand Up @@ -271,7 +270,9 @@ def test_timestamp_filter_uses_start_and_end(self, mock_utc_now, mock_block):

sql = client.query.call_args[0][0]
assert "2023-01-01T00:00:00" in sql # start_date
assert "2024-01-01T00:00:00" in sql # end_date (appears twice: WHERE + entity_ts value)
assert (
"2024-01-01T00:00:00" in sql
) # end_date (appears twice: WHERE + entity_ts value)
assert "BETWEEN TIMESTAMP(" in sql

@patch("feast.infra.offline_stores.bigquery.block_until_done")
Expand Down Expand Up @@ -319,9 +320,9 @@ def test_sets_table_expiry(self, mock_utc_now, mock_block):
client.update_table.assert_called_once()
updated_table = client.update_table.call_args[0][0]
# expiry should be 30 minutes after _utc_now()
assert updated_table.expires == datetime(2024, 1, 1, tzinfo=timezone.utc) + timedelta(
minutes=30
)
assert updated_table.expires == datetime(
2024, 1, 1, tzinfo=timezone.utc
) + timedelta(minutes=30)


# ---------------------------------------------------------------------------
Expand All @@ -338,7 +339,9 @@ def repo_config():
def mock_bq_client():
client = MagicMock()
client.project = "my-project"
client.query.return_value = MagicMock(state="DONE", exception=lambda timeout=None: None)
client.query.return_value = MagicMock(
state="DONE", exception=lambda timeout=None: None
)
client.get_table.return_value = MagicMock()
return client

Expand All @@ -348,8 +351,12 @@ class TestGetHistoricalFeaturesNonEntityMode:
@patch("feast.infra.offline_stores.bigquery._utc_now")
@patch("feast.infra.offline_stores.bigquery._bq_create_entity_union_table")
@patch("feast.infra.offline_stores.bigquery._upload_entity_df")
@patch("feast.infra.offline_stores.bigquery.offline_utils.get_feature_view_query_context")
@patch("feast.infra.offline_stores.bigquery.offline_utils.build_point_in_time_query")
@patch(
"feast.infra.offline_stores.bigquery.offline_utils.get_feature_view_query_context"
)
@patch(
"feast.infra.offline_stores.bigquery.offline_utils.build_point_in_time_query"
)
@patch("feast.infra.offline_stores.bigquery._get_table_reference_for_new_entity")
@patch("feast.infra.offline_stores.bigquery._get_bigquery_client")
def test_non_entity_mode_calls_union_table_not_upload(
Expand Down Expand Up @@ -403,8 +410,12 @@ def test_non_entity_mode_calls_union_table_not_upload(
@patch("feast.infra.offline_stores.bigquery._utc_now")
@patch("feast.infra.offline_stores.bigquery._bq_create_entity_union_table")
@patch("feast.infra.offline_stores.bigquery._upload_entity_df")
@patch("feast.infra.offline_stores.bigquery.offline_utils.get_feature_view_query_context")
@patch("feast.infra.offline_stores.bigquery.offline_utils.build_point_in_time_query")
@patch(
"feast.infra.offline_stores.bigquery.offline_utils.get_feature_view_query_context"
)
@patch(
"feast.infra.offline_stores.bigquery.offline_utils.build_point_in_time_query"
)
@patch("feast.infra.offline_stores.bigquery._get_table_reference_for_new_entity")
@patch("feast.infra.offline_stores.bigquery._get_bigquery_client")
def test_non_entity_mode_uses_entity_ts_as_timestamp_col(
Expand Down Expand Up @@ -455,8 +466,12 @@ def test_non_entity_mode_uses_entity_ts_as_timestamp_col(
@patch("feast.infra.offline_stores.bigquery._utc_now")
@patch("feast.infra.offline_stores.bigquery._bq_create_entity_union_table")
@patch("feast.infra.offline_stores.bigquery._upload_entity_df")
@patch("feast.infra.offline_stores.bigquery.offline_utils.get_feature_view_query_context")
@patch("feast.infra.offline_stores.bigquery.offline_utils.build_point_in_time_query")
@patch(
"feast.infra.offline_stores.bigquery.offline_utils.get_feature_view_query_context"
)
@patch(
"feast.infra.offline_stores.bigquery.offline_utils.build_point_in_time_query"
)
@patch("feast.infra.offline_stores.bigquery._get_table_reference_for_new_entity")
@patch("feast.infra.offline_stores.bigquery._get_bigquery_client")
def test_non_entity_mode_passes_start_and_end_to_union_table(
Expand Down Expand Up @@ -507,8 +522,12 @@ def test_non_entity_mode_passes_start_and_end_to_union_table(
@patch("feast.infra.offline_stores.bigquery.block_until_done")
@patch("feast.infra.offline_stores.bigquery._utc_now")
@patch("feast.infra.offline_stores.bigquery._bq_create_entity_union_table")
@patch("feast.infra.offline_stores.bigquery.offline_utils.get_feature_view_query_context")
@patch("feast.infra.offline_stores.bigquery.offline_utils.build_point_in_time_query")
@patch(
"feast.infra.offline_stores.bigquery.offline_utils.get_feature_view_query_context"
)
@patch(
"feast.infra.offline_stores.bigquery.offline_utils.build_point_in_time_query"
)
@patch("feast.infra.offline_stores.bigquery._get_table_reference_for_new_entity")
@patch("feast.infra.offline_stores.bigquery._get_bigquery_client")
def test_non_entity_mode_returns_retrieval_job(
Expand Down Expand Up @@ -553,8 +572,12 @@ def test_non_entity_mode_returns_retrieval_job(
@patch("feast.infra.offline_stores.bigquery.block_until_done")
@patch("feast.infra.offline_stores.bigquery._utc_now")
@patch("feast.infra.offline_stores.bigquery._bq_create_entity_union_table")
@patch("feast.infra.offline_stores.bigquery.offline_utils.get_feature_view_query_context")
@patch("feast.infra.offline_stores.bigquery.offline_utils.build_point_in_time_query")
@patch(
"feast.infra.offline_stores.bigquery.offline_utils.get_feature_view_query_context"
)
@patch(
"feast.infra.offline_stores.bigquery.offline_utils.build_point_in_time_query"
)
@patch("feast.infra.offline_stores.bigquery._get_table_reference_for_new_entity")
@patch("feast.infra.offline_stores.bigquery._get_bigquery_client")
def test_non_entity_mode_metadata_excludes_timestamp_col_from_keys(
Expand Down Expand Up @@ -610,9 +633,15 @@ class TestGetHistoricalFeaturesEntityDfMode:
@patch("feast.infra.offline_stores.bigquery._get_entity_df_event_timestamp_range")
@patch("feast.infra.offline_stores.bigquery._get_entity_schema")
@patch("feast.infra.offline_stores.bigquery.offline_utils.get_expected_join_keys")
@patch("feast.infra.offline_stores.bigquery.offline_utils.assert_expected_columns_in_entity_df")
@patch("feast.infra.offline_stores.bigquery.offline_utils.get_feature_view_query_context")
@patch("feast.infra.offline_stores.bigquery.offline_utils.build_point_in_time_query")
@patch(
"feast.infra.offline_stores.bigquery.offline_utils.assert_expected_columns_in_entity_df"
)
@patch(
"feast.infra.offline_stores.bigquery.offline_utils.get_feature_view_query_context"
)
@patch(
"feast.infra.offline_stores.bigquery.offline_utils.build_point_in_time_query"
)
@patch("feast.infra.offline_stores.bigquery._get_table_reference_for_new_entity")
@patch("feast.infra.offline_stores.bigquery._get_bigquery_client")
def test_entity_df_mode_calls_upload_not_union_table(
Expand Down Expand Up @@ -671,9 +700,15 @@ def test_entity_df_mode_calls_upload_not_union_table(
@patch("feast.infra.offline_stores.bigquery._get_entity_df_event_timestamp_range")
@patch("feast.infra.offline_stores.bigquery._get_entity_schema")
@patch("feast.infra.offline_stores.bigquery.offline_utils.get_expected_join_keys")
@patch("feast.infra.offline_stores.bigquery.offline_utils.assert_expected_columns_in_entity_df")
@patch("feast.infra.offline_stores.bigquery.offline_utils.get_feature_view_query_context")
@patch("feast.infra.offline_stores.bigquery.offline_utils.build_point_in_time_query")
@patch(
"feast.infra.offline_stores.bigquery.offline_utils.assert_expected_columns_in_entity_df"
)
@patch(
"feast.infra.offline_stores.bigquery.offline_utils.get_feature_view_query_context"
)
@patch(
"feast.infra.offline_stores.bigquery.offline_utils.build_point_in_time_query"
)
@patch("feast.infra.offline_stores.bigquery._get_table_reference_for_new_entity")
@patch("feast.infra.offline_stores.bigquery._get_bigquery_client")
def test_entity_df_sql_string_mode_works(
Expand Down
Loading