Visitar URL original
feat: Add remote materialization support via feature server by aniketpalu · Pull Request #6590 · feast-dev/feast · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed lint errors & minor formatting
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
  • Loading branch information
aniketpalu committed Jul 8, 2026
commit 82ce777cd4e082bbc1ca6945d32ea1c10e0039d5
8 changes: 2 additions & 6 deletions sdk/python/feast/feature_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -2295,9 +2295,7 @@ def on_change(result: FVResult):
failed = [r for r in results if r.status == FVMaterializationStatus.FAILED]
if failed:
names = ", ".join(r.name for r in failed)
errors = "; ".join(
f"{r.name}: {r.error}" for r in failed if r.error
)
errors = "; ".join(f"{r.name}: {r.error}" for r in failed if r.error)
msg = f"Remote materialization failed for: {names}"
if errors:
msg += f" ({errors})"
Expand Down Expand Up @@ -2381,9 +2379,7 @@ def on_change(result: FVResult):
failed = [r for r in results if r.status == FVMaterializationStatus.FAILED]
if failed:
names = ", ".join(r.name for r in failed)
errors = "; ".join(
f"{r.name}: {r.error}" for r in failed if r.error
)
errors = "; ".join(f"{r.name}: {r.error}" for r in failed if r.error)
msg = f"Remote incremental materialization failed for: {names}"
if errors:
msg += f" ({errors})"
Expand Down
6 changes: 2 additions & 4 deletions sdk/python/feast/materialization_status.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import logging
import time
from dataclasses import dataclass, field
from dataclasses import dataclass
from enum import Enum
from typing import Callable, Dict, List, Optional, Set

Expand Down Expand Up @@ -67,9 +67,7 @@ def poll_materialization_status(
elapsed = time.monotonic() - start

if current != previous_statuses.get(name):
result = FVResult(
name=name, status=current, elapsed_seconds=elapsed
)
result = FVResult(name=name, status=current, elapsed_seconds=elapsed)
results[name] = result
previous_statuses[name] = current
if on_status_change:
Expand Down
13 changes: 5 additions & 8 deletions sdk/python/tests/unit/test_remote_materialize.py
Original file line number Diff line number Diff line change
@@ -1,21 +1,17 @@
"""Tests for remote materialization: shared poller, client-side delegation, and async endpoints."""

import time
from datetime import datetime, timedelta, timezone
from datetime import datetime, timezone
from unittest.mock import MagicMock, patch

import pytest
from fastapi.testclient import TestClient

from feast.feature_server import get_app
from feast.feature_view import FeatureViewState
from feast.materialization_status import (
FVMaterializationStatus,
FVResult,
poll_materialization_status,
)


# ---------------------------------------------------------------------------
# Tests for poll_materialization_status
# ---------------------------------------------------------------------------
Expand All @@ -39,7 +35,10 @@ def status_fn(name):

def test_mixed_results(self):
"""One FV succeeds, one fails."""
statuses = {"fv_a": FVMaterializationStatus.SUCCEEDED, "fv_b": FVMaterializationStatus.FAILED}
statuses = {
"fv_a": FVMaterializationStatus.SUCCEEDED,
"fv_b": FVMaterializationStatus.FAILED,
}

def status_fn(name):
return statuses[name]
Expand Down Expand Up @@ -235,8 +234,6 @@ def test_materialize_delegates_when_remote_mode(self, mock_remote):
fs.config.feature_server.materialize_mode = "remote"
fs.config.feature_server.url = "http://feast-server:80"

from feast.feature_store import FeatureStore

# Call the unbound method with our mock self
fs._is_remote_materialize_mode = MagicMock(return_value=True)
fs._remote_materialize = MagicMock()
Expand Down
3 changes: 0 additions & 3 deletions sdk/python/tests/unit/test_remote_materialize_e2e.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,9 @@
FV state transitions → client polls registry → returns success
"""

import os
import tempfile
import threading
import time
from datetime import datetime, timedelta, timezone
from pathlib import Path

import pandas as pd
import pytest
Expand Down
Loading