Visitar URL original
feat(operator): Auto-create RBAC for spark_application batch engine by aniketpalu · Pull Request #6597 · feast-dev/feast · GitHub
Skip to content

feat(operator): Auto-create RBAC for spark_application batch engine #6597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 8 commits into from
Jul 18, 2026
Merged

feat(operator): Auto-create RBAC for spark_application batch engine #6597

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c6f4387
feat(operator): auto-create RBAC for spark_application batch engine
aniketpalu Jul 9, 2026
d1b3f50
fix(operator): bake default batch-driver SA into feature_store.yaml
aniketpalu Jul 14, 2026
a769e04
fix(operator): inject batch-driver SA only for spark_application
aniketpalu Jul 16, 2026
eaded80
Merge branch 'master' into feat/operator-batch-engine-rbac
aniketpalu Jul 16, 2026
1512284
Merge branch 'master' into feat/operator-batch-engine-rbac
aniketpalu Jul 17, 2026
f849569
chore(operator): fix CI fmt and secrets baseline
aniketpalu Jul 17, 2026
05feaa1
Merge branch 'master' into feat/operator-batch-engine-rbac
aniketpalu Jul 18, 2026
3c00206
refactor(operator): parse batch-engine ConfigMap once per reconcile
aniketpalu Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor(operator): parse batch-engine ConfigMap once per reconcile 
Share getBatchEngineConfig() for engine type and driver SA resolution
instead of fetching/parsing the same ConfigMap twice.

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
  • Loading branch information
@aniketpalu
aniketpalu committed Jul 18, 2026
commit 3c00206f2b06837b44f27db871c925c96973aeed
58 changes: 17 additions & 41 deletions infra/feast-operator/internal/controller/services/batch_engine_rbac.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,12 @@ func loadBatchEngineTemplate(engineType string) (*BatchEngineRBACTemplate, error
}

func (feast *FeastServices) reconcileBatchEngineRBAC() error {
engineType := feast.getBatchEngineType()
config, ok := feast.getBatchEngineConfig()
if !ok {
return feast.deleteBatchEngineRBAC()
}

engineType, _ := config["type"].(string)
if engineType == "" {
return feast.deleteBatchEngineRBAC()
}
Expand All @@ -93,7 +98,7 @@ func (feast *FeastServices) reconcileBatchEngineRBAC() error {
}

if tmpl.Driver != nil {
driverSAName := feast.getBatchDriverSAName()
driverSAName := resolveBatchDriverSAName(feast.Handler.FeatureStore, config)
if tmpl.Driver.CreateServiceAccount {
if err := feast.ensureBatchDriverServiceAccount(driverSAName); err != nil {
return err
Expand All @@ -110,10 +115,12 @@ func (feast *FeastServices) reconcileBatchEngineRBAC() error {
return nil
}

func (feast *FeastServices) getBatchEngineType() string {
// getBatchEngineConfig returns the parsed batch-engine ConfigMap data.
// ok=false means no batch engine is configured or the ConfigMap is unreadable.
func (feast *FeastServices) getBatchEngineConfig() (map[string]interface{}, bool) {
appliedSpec := feast.Handler.FeatureStore.Status.Applied
if appliedSpec.BatchEngine == nil || appliedSpec.BatchEngine.ConfigMapRef == nil {
return ""
return nil, false
}

configMapKey := appliedSpec.BatchEngine.ConfigMapKey
Expand All @@ -123,21 +130,19 @@ func (feast *FeastServices) getBatchEngineType() string {

cm, err := feast.getConfigMap(appliedSpec.BatchEngine.ConfigMapRef.Name)
if err != nil {
return ""
return nil, false
}

data, ok := cm.Data[configMapKey]
if !ok {
return ""
data, found := cm.Data[configMapKey]
if !found {
return nil, false
}

var config map[string]interface{}
if err := yaml.Unmarshal([]byte(data), &config); err != nil {
return ""
return nil, false
}

engineType, _ := config["type"].(string)
return engineType
return config, true
}

// resolveBatchDriverSAName returns the ServiceAccount name for the Spark driver.
Expand All @@ -150,35 +155,6 @@ func resolveBatchDriverSAName(featureStore *feastdevv1.FeatureStore, config map[
return GetFeastServiceName(featureStore, BatchDriverFeastType)
}

func (feast *FeastServices) getBatchDriverSAName() string {
appliedSpec := feast.Handler.FeatureStore.Status.Applied
if appliedSpec.BatchEngine == nil || appliedSpec.BatchEngine.ConfigMapRef == nil {
return feast.GetFeastServiceName(BatchDriverFeastType)
}

configMapKey := appliedSpec.BatchEngine.ConfigMapKey
if configMapKey == "" {
configMapKey = "config"
}

cm, err := feast.getConfigMap(appliedSpec.BatchEngine.ConfigMapRef.Name)
if err != nil {
return feast.GetFeastServiceName(BatchDriverFeastType)
}

data, ok := cm.Data[configMapKey]
if !ok {
return feast.GetFeastServiceName(BatchDriverFeastType)
}

var config map[string]interface{}
if err := yaml.Unmarshal([]byte(data), &config); err != nil {
return feast.GetFeastServiceName(BatchDriverFeastType)
}

return resolveBatchDriverSAName(feast.Handler.FeatureStore, config)
}

func (feast *FeastServices) ensureBatchEngineRole(feastType FeastServiceType, rules []rbacv1.PolicyRule) error {
logger := log.FromContext(feast.Handler.Context)
role := &rbacv1.Role{
Expand Down
Loading