Visitar URL original
fix: Use join keys instead of entity names in ODFV materialization by anshishrivastava · Pull Request #6645 · feast-dev/feast · GitHub
Skip to content

fix: Use join keys instead of entity names in ODFV materialization #6645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 2 commits into from
Jul 30, 2026
Merged

fix: Use join keys instead of entity names in ODFV materialization #6645

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a07a064
fix: Use join keys instead of entity names in ODFV materialization
anshishrivastava Jul 24, 2026
71463c6
style: Apply ruff format
anshishrivastava Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
style: Apply ruff format 
Signed-off-by: Anshi Shrivastava <anshi4shrivastava@gmail.com>
  • Loading branch information
@anshishrivastava @ntkathole
anshishrivastava authored and ntkathole committed Jul 30, 2026
commit 71463c673b596c6ebda88d13519b29b2a80a5084
4 changes: 1 addition & 3 deletions sdk/python/tests/unit/local_feast_tests/test_local_feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,9 +565,7 @@ def transform(features_df: pd.DataFrame) -> pd.DataFrame:
# FeastJoinKeysDuringMaterialization because _materialize_odfv
# queried the offline store for a column named "id" (the entity
# name) instead of "id_join_key" (the actual join key column).
test_feature_store.materialize_incremental(
end_date=datetime.now(timezone.utc)
)
test_feature_store.materialize_incremental(end_date=datetime.now(timezone.utc))

response = test_feature_store.get_online_features(
features=["my_odfv:label"],
Expand Down
Loading