Visitar URL original
feat(server): Remote Materialization by aniketpalu · Pull Request #6649 · feast-dev/feast · GitHub
Skip to content

feat(server): Remote Materialization #6649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 13 commits into from
Aug 6, 2026
Merged

feat(server): Remote Materialization #6649

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f61be7d
feat(server): Add async materialization via ?async=true query param
aniketpalu Jul 28, 2026
9e121fc
Merge branch 'master' into feat/remote-materialize-v2
aniketpalu Jul 28, 2026
6c3aaa7
feat(server): Add async materialization via ?async=true query param
aniketpalu Jul 28, 2026
1384c60
feat(sdk): Auto-delegate materialize to feature server when online_st…
aniketpalu Jul 28, 2026
9a97b70
fix: Conflicts resolved
aniketpalu Jul 28, 2026
b5cb173
fix(server): Let store own MATERIALIZING transitions on async path
aniketpalu Jul 28, 2026
dc6f965
Merge branch 'master' into feat/remote-materialize-v2
aniketpalu Jul 30, 2026
d8e7a99
fix: Address #6649 review — run_async, race reserve, version threading
aniketpalu Jul 31, 2026
059c2d2
Merge branch 'master' into feat/remote-materialize-v2
aniketpalu Aug 2, 2026
c602fe3
fix(server): Only reset MATERIALIZING FVs on async materialize failure
aniketpalu Aug 5, 2026
7909fc4
fix: Default run_async to False and cover version forwarding
aniketpalu Aug 5, 2026
b8aa6e7
Merge branch 'master' into feat/remote-materialize-v2
aniketpalu Aug 6, 2026
a2810c8
fix(server): Use dedicated executor for async materialize
aniketpalu Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(server): Only reset MATERIALIZING FVs on async materialize failure 
Avoid wiping AVAILABLE_ONLINE when a post-success exception fires
(e.g. SparkApp CR already cleaned up). Reuse the stuck-state helper
so true failures still return to GENERATED.

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
  • Loading branch information
@aniketpalu
aniketpalu committed Aug 5, 2026
commit c602fe300aa2fa60d7e270dee8de46714a8149ff
4 changes: 2 additions & 2 deletions sdk/python/feast/feature_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -974,7 +974,7 @@ def _run_materialize():
f"Async materialization failed for {fv_names}: {e}",
exc_info=True,
)
_update_fv_state(store, fv_names, FeatureViewState.GENERATED)
_reset_stuck_materializing_to_generated(store, fv_names)

loop = asyncio.get_running_loop()
loop.run_in_executor(None, _run_materialize)
Expand Down Expand Up @@ -1029,7 +1029,7 @@ def _run_materialize_incremental():
f"Async materialize-incremental failed for {fv_names}: {e}",
exc_info=True,
)
_update_fv_state(store, fv_names, FeatureViewState.GENERATED)
_reset_stuck_materializing_to_generated(store, fv_names)

loop = asyncio.get_running_loop()
loop.run_in_executor(None, _run_materialize_incremental)

@ntkathole ntkathole Jul 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking but I think it's better if we used dedicated executor, instead of default shared pool, for materialization so that it won't block other operations if multiple executors in progress

@aniketpalu aniketpalu Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, added separate executor

Expand Down
Loading